Help I have a problem with a wrong answer

Question

0.00/5 (No votes)

See more:

Let's see the question.
You are looking at the floor plan of the Summer Informatics School's new building. You were tasked with SIS logistics, so you really care about travel time between different locations: it is important to know how long it would take to get from the lecture room to the canteen, or from the gym to the server room.

The building consists of n towers, h floors each, where the towers are labeled from 1 to n, the floors are labeled from 1 to h. There is a passage between any two adjacent towers (two towers i and i + 1 for all i: 1 ≤ i ≤ n - 1) on every floor x, where a ≤ x ≤ b. It takes exactly one minute to walk between any two adjacent floors of a tower, as well as between any two adjacent towers, provided that there is a passage on that floor. It is not permitted to leave the building.

You have given k pairs of locations (ta, fa), (tb, fb): floor fa of tower ta and floor fb of tower tb. For each pair you need to determine the minimum walking time between these locations.
Input

The first line of the input contains following integers:

n: the number of towers in the building (1 ≤ n ≤ 108),
h: the number of floors in each tower (1 ≤ h ≤ 108),
a and b: the lowest and highest floor where it's possible to move between adjacent towers (1 ≤ a ≤ b ≤ h),
k: total number of queries (1 ≤ k ≤ 104).

Next k lines contain description of the queries. Each description consists of four integers ta, fa, tb, fb (1 ≤ ta, tb ≤ n, 1 ≤ fa, fb ≤ h). This corresponds to a query to find the minimum travel time between fa-th floor of the ta-th tower and fb-th floor of the tb-th tower.
Output

For each query print a single integer: the minimum walking time between the locations in minutes.

I was creat the with c++
in one question is true,,
but in two question is false,,

Example
Input

3 6 2 3 3
1 2 1 3
1 4 3 4
1 2 2 3

Output
1
4
2

What I have tried:

#include <iostream>
using namespace std;
int main()
{
	int z = 0;
	int tower;
	int floorr;
	int lowfloor;
	int highfloor;
	int queries;
	cin >> tower;
	cin >> floorr;
	cin >> lowfloor;
	cin >> highfloor;
	cin >> queries;
	int arr[queries*4];
	for(int i = 0; i < queries*4; i++)
	{
		cin >> arr[i];
	}
	for(int i = 0; i < queries; i++)
	{
		if(arr[z] == arr[z+2])
		{
			if(arr[z+1] < arr[z+3])
			{
				cout << arr[z+3] - arr[z+1] << endl;
			}
		}
		else if(arr[z] < arr[z+2])
		{
			if(arr[z+1] <= lowfloor)
			{
				if(arr[z+3] >= lowfloor)
				{
					cout << lowfloor - arr[z+1] + arr[z+2] - arr[z] + arr[z+3] - lowfloor << endl;
				}
				else if(arr[z+3] < lowfloor)
				{
					cout << lowfloor - arr[z+1] + arr[z+2] - arr[z] + lowfloor - arr[z+3] << endl;
				}
			}
			else if(arr[z+1] > lowfloor && arr[z+1] < highfloor)
			{
				if(arr[z+1] < arr[z+3])
				{
					cout << arr[z+2] - arr[z] + arr[z+3] - arr[z+1] << endl; 
				}
				else if(arr[z+1] > arr[z+3])
				{
					cout << arr[z+2] - arr[z] + arr[z+1] - arr[z+3] << endl;
				}
			}
			else if(arr[z+1] >= highfloor)
			{
				if(arr[z+3] > highfloor)
				{
					cout << arr[z+1] - highfloor + arr[z+2] - arr[z] + arr[z+3] - highfloor << endl;
				}
				else if(arr[z+3] < highfloor)
				{
					cout << arr[z+1] - highfloor + arr[z+2] - arr[z] + highfloor - arr[z+3] << endl;
				}
			}
		}

		else if(arr[z] > arr[z+2])
		{
			if(arr[z+1] <= lowfloor)
			{
				if(arr[z+3] >= lowfloor)
				{
					cout << lowfloor - arr[z+1] + arr[z] - arr[z+2] + arr[z+3] - lowfloor << endl;
				}
				else if(arr[z+3] < lowfloor)
				{
					cout << lowfloor - arr[z+1] + arr[z] - arr[z+2] + lowfloor - arr[z+3] << endl;
				}
			}
			else if(arr[z+1] > lowfloor && arr[z+1] < highfloor)
			{
				if(arr[z+1] < arr[z+3])
				{
					cout << arr[z] - arr[z+2] + arr[z+3] - arr[z+1] << endl; 
				}
				else if(arr[z+1] > arr[z+3])
				{
					cout << arr[z] - arr[z+2] + arr[z+1] - arr[z+3] << endl;
				}
			}
			else if(arr[z+1] >= highfloor)
			{
				if(arr[z+3] > highfloor)
				{
					cout << arr[z+1] - highfloor + arr[z] - arr[z+2] + arr[z+3] - highfloor << endl;
				}
				else if(arr[z+3] < highfloor)
				{
					cout << arr[z+1] - highfloor + arr[z] - arr[z+2] + highfloor - arr[z+3] << endl;
				}
			}
		}
		z = z + 4;
	}
	return 0;
}

Posted 13-Aug-18 18:31pm

Member 13906640

Updated 13-Aug-18 20:09pm

Add a Solution

Comments

Patrice T 14-Aug-18 0:51am

Describe the problem. with more details.

Member 13906640 14-Aug-18 1:24am

I don't know where the wrong part of my script is, therefore I want to ask here what is wrong from my script :(

Patrice T 14-Aug-18 1:30am

Describe how result is wrong.

KarstenK 14-Aug-18 5:07am

You need to debug the code. Start by providing some output of the steps of computation.

Your code doesnt compile!!!

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2018-08-13T19:26:00

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:

Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16

Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:

C#

int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

Patrice T · Answer 2 · 2018-08-13T20:09:00

Quote:
in one question is true,,
but in two question is false,,

Lets guess: your code is handling some cases correctly and other not correctly.
As programmer, your job is also to ensure your code is correct.
Use the debugger to watch how your code perform.
You know wich answer is wrong, you know how the case should be handled, use the debugger to see what your code really do.

C++

if(arr[z] == arr[z+2])
{
    if(arr[z+1] < arr[z+3])
    {
        cout << arr[z+3] - arr[z+1] << endl;
    }
}

In this code, what are you doing when arr[z+1] > arr[z+3] or when

arr[z+1] = arr[z+3]

?

-----
Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your cpde is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

The downside of this solution:
- It is a DIY, you are the one tracking the problem and finding its roots, which lead to the solution.
The upside of this solution:
- It is also a great learning tool because it show you reality and you can see which expectation match reality.

secondary effects
- Your will be proud of finding bugs yourself.
- Your learning skills will improve.

You should find pretty quickly what is wrong.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
1.11 — Debugging your program (stepping and breakpoints) | Learn C++[^]
The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

Help I have a problem with a wrong answer

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0