How can I save select option into database using PHP?

Question

1.00/5 (1 vote)

See more:

I got an error says:

Error: INSERT INTO dbstation(From, To, Date) values('fAG', 'tkulim', '2018-09-30') You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'From, To, Date) values('fAG', 'tkulim', '2018-09-30')' at line 1

Can you help me to solve this problem? thanks in advance.

This is my html code:

<html>
<head>
	<title>Main Menu</title>
	<link rel="stylesheet" type="text/css" href="menu_style.css">
	<link rel="stylesheet" type="text/css" href="Datepicker.css">

</head>
<body>

<div class="menu">
	<!-- <div class="btn"> -->
	<a href="main.html"><button class="btn">Booking</button></a>
	<a href="history.html"><button class="btn">History</button></a>
	<a href="reservation.html"><button class="btn">Reservation</button></a>
	<a href="trainpay.html"><button class="btn">TrainPay</button></a>
	<a href="reservation.html"><button class="btn">Update profile</button></a>
	<br><br><br>
<!-- </div> -->
<!-- <div class="station"> -->
<form align="center" method="post" action="station.php">
	From
	<select name="from">
		<option value="fkluang">Kluang, Johor</option>
		<option value="fAG">Alor Gajah, Melaka</option>
		<option value="fSenawang">Senawang, NS</option>
		<option value="fKL">KL Sentral, KL</option>
		<option value="fipoh">Ipoh, Perak</option>
		<option value="fkulim">Kulim, Kedah</option>
		<option value="fkangar">Kangar, Perlis</option>
	</select>
	 
	 
	To
	<select name="to">
		<option value="tkluang">Kluang, Johor</option>
		<option value="tAG">Alor Gajah, Melaka</option>
		<option value="tSenawang">Senawang, NS</option>
		<option value="tKL">KL Sentral, KL</option>
		<option value="tipoh">Ipoh, Perak</option>
		<option value="tkulim">Kulim, Kedah</option>
		<option value="tkangar">Kangar, Perlis</option>
	</select>
	 
	 
	<label>Date: </label>
	<input name="datee" type="date"/>

	<!-- Button to choose schedule -->
	<a href="schedule.html"><button align="right" class="button" name="go">go</button></a>
</form>

	</div>	
	      <div class="tr">
		  <img id='train-route' 
            src="train_route.jpg" 
            alt="" 
            width="900" 
            height="450" />
			</div>
</body>
</html>

What I have tried:

<?php
	
	$from = filter_input(INPUT_POST, 'from');
	$to = filter_input(INPUT_POST, 'to');
	$datee = filter_input(INPUT_POST, 'datee');
	
	if (!empty($from)){
	if (!empty($to)){
	if (!empty($datee)){

	$host = "localhost";
	$dbusername = "root";
	$dbpassword = "";
	$dbname = "station";

	// Create connection
	$conn = new mysqli ($host, $dbusername, $dbpassword, $dbname);
	if(mysqli_connect_error())
	{
		die('Connect Error('.mysqli_connect_errno().')'.mysqli_connect_error());

	}
	else
	{
		$sql = "INSERT INTO dbstation(From, To, Date) values('$from', '$to', '$datee')";
		if($conn->query($sql))
		{
			echo "New record is inserted successfully";
		}
		else
		{
			echo "Error: ".$sql."
			".$conn->error;
		}
		$conn->close();
	}
	}
	else
	 {
		// echo "Date should not be empty";
		// die();
	 }
	 }
	 else{
		// echo "Password should not be empty";
		// die();
	 }
	 }
	 else{
		// echo "Username should not be empty";
		// die();
	 }
?>

Posted 27-Sep-18 6:30am

Member 13620781

Updated 13-Oct-18 2:57am

Add a Solution

Comments

Richard Deeming 16-Oct-18 12:21pm

Your code is vulnerable to SQL Injection[^]. NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]
PHP: SQL Injection - Manual[^]

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

HappyPines · Answer 1 · 2018-10-13T02:57:00

try this Sir.

<!DOCTYPE html>
<html lang="en">
<head>
<title>Main Menu</title>
</head>
<body>

<form align="center" method="post" action="station.php" enctype="multipart/form-data">
From
<select name="from" required="true">
<option value="fkluang">Kluang, Johor</option>
<option value="fAG">Alor Gajah, Melaka</option>
<option value="fSenawang">Senawang, NS</option>
<option value="fKL">KL Sentral, KL</option>
<option value="fipoh">Ipoh, Perak</option>
<option value="fkulim">Kulim, Kedah</option>
<option value="fkangar">Kangar, Perlis</option>
</select>

To
<select name="to" required="true">
<option value="tkluang">Kluang, Johor</option>
<option value="tAG">Alor Gajah, Melaka</option>
<option value="tSenawang">Senawang, NS</option>
<option value="tKL">KL Sentral, KL</option>
<option value="tipoh">Ipoh, Perak</option>
<option value="tkulim">Kulim, Kedah</option>
<option value="tkangar">Kangar, Perlis</option>
</select>

<label>Date: </label>
<input name="datee" type="date"/ required="true">

<button align="right" class="submit" name="go">go</button>
</form>

</body>
</html>

//PHP

<?php

$From = $_POST['from'];

$To = $_POST['to'];

$Datee = $_POST['datee'];

$servername = "localhost";
$username = "root";
$password = "";
$dbname = "helping";

// Create connection
$conn = new mysqli($servername, $username, $password, $dbname);
// Check connection
if ($conn->connect_error) {
die("Connection failed: " . $conn->connect_error);
}

$sql = "INSERT INTO station (s_from, s_to, s_date) VALUES ('$From', '$To', '$Datee')";

if ($conn->query($sql) === TRUE) {
echo "New record created successfully";
} else {
echo "Something went wrong";
}

$conn->close();

?>