Help with adding items to a listview using C#

Question

3.67/5 (3 votes)

See more:

Hi,

I'm a beginner and just need some help solving this problem.

I think its simple but have tried to figure it out but im getting no where.
I currently have four text boxes to which I add data then click the add to add this to the listview.

I am able to add the first time but then can not add again also this does not add data from the first text box to the first column but leaves the first column out and starts from the second column.

below is the code

C#

ListViewItem item1 = new ListViewItem();
// add items.
item1.SubItems.Add((Convert.ToString(StudentHouses.HouseNo)));
item1.SubItems.Add((StudentHouses.AddressLine1));
item1.SubItems.Add((StudentHouses.AddressLine2));
item1.SubItems.Add((StudentHouses.AddressLine3));
//Add the items to the ListView.
listView1.Items.Add( item1 );
this.Controls.Add(listView1);

Any help would be appreciated.
thankyou

[edit]Subject: Don't SHOUT. All uppercase is considered SHOUTING on the internet, and rude - OriginalGriff[/edit]

Posted 13-Mar-11 10:51am

BEGINNERINEED

Updated 13-Mar-11 11:24am

OriginalGriff

v4

Add a Solution

Comments

Dalek Dave 13-Mar-11 17:06pm

Edited for Readability.

Sergey Alexandrovich Kryukov 13-Mar-11 19:26pm

You attempt would be correct, but ListViewControl does not exactly what do you think.
This is because this control is ugly in certain respect.
However, if your simply looked at help you would easily find the resolution yourself.
--SA

BEGINNERINEED 16-Mar-11 15:20pm

ive looked for help where possible by exploring various methods but have struggled and i thought the best thing would be to ask the experts which is very much appreciated, but still im struggling to add multiple times to the listview and it only adds the first time, why would this be?

Sergey Alexandrovich Kryukov 16-Mar-11 15:31pm

You code does not show this problem. Did you add columns properly? Do you change the index of sub-item properly. Usual mistake is repeating same operation several times. Use proper loop.
--SA

BEGINNERINEED 16-Mar-11 17:12pm

i think i have added the columns properyly but yes i have not at anytime changed the index as ive used no loop to iterate through the items being added

2 solutions

Solution 1

Not sure why you wouldn't be able to add again unless your trying to add a duplicate list view item, try calling listView1.Items.Clear();

With regards to the starting at second column it is confusing I found also. The item text appears in the first column and sub items start at column two. This means your code should be more like: (included other adaptations as well)

C#

//Clear listView1 items.
listView1.Items.Clear();

//Create item1
ListViewItem item1 = new ListViewItem();

//Set Text which represents first column
item1.Text = Convert.ToString(StudentHouses.HouseNo);

//Add sub items starting with second column
item1.SubItems.Add((StudentHouses.AddressLine1));
item1.SubItems.Add((StudentHouses.AddressLine2));
item1.SubItems.Add((StudentHouses.AddressLine3));

//Add the items to the ListView.
listView1.Items.Add( item1 );

//Add listView1 control if it has not already been added
if(!this.Controls.Contains(listView1))
{
    this.Controls.Add(listView1);
}

Posted 13-Mar-11 11:27am

Ed Nutting

Comments

Sergey Alexandrovich Kryukov 13-Mar-11 19:24pm

Now it's correct, my 5.
Also, a shorter way is ListViewItem item1 = new ListViewItem(StudentHouses.HouseNo.ToString());
(Text property assignment would be redundant.)
--SA

Ed Nutting 14-Mar-11 3:19am

'Not' or 'Now'? :P And yes but I wanted to demonstrate the concept better so used text property instead :).

Sergey Alexandrovich Kryukov 14-Mar-11 3:35am

Thanks for correcting me.
--SA

BEGINNERINEED 16-Mar-11 15:07pm

thanks for the demo, i have it adding to the listview starting from column1 now, however am still not able to add the second time, do you think i am better of using a loop or is it something else that im doing wrong as it only adds the first time to the listview

Sergey Alexandrovich Kryukov 16-Mar-11 15:35pm

Rather, you need to separate model and UI presentation. Have a distinct model in pure data, no UI and separate mapping between them, never repeating a single line of code as you do in your SubItems.Add. Sure, a cycle.
Look, check from time to time my profile. I'm getting ready the article, the demo uses a tree view iterating through enumeration type. In the mean while please see my very last article on enumeration and locate "Enumeration Types do not Enumerate! Working around .NET and Language Limitations", to get some ideas (there is not list view there, but will be in my future new article, really soon).
--SA

BEGINNERINEED 16-Mar-11 17:18pm

yea sure i will look at your article, in the meanwhile can you show me a small line of code which i could use to iterate through the listview to add items just as an example to get me started

Ed Nutting 16-Mar-11 17:23pm

Try this:

<pre lang="C#">for(int i = 0; i < 10; i++)
{
ListViewItem item1 = new ListViewItem();
item1.Name = "Item" + i.ToString();
//Set Text which represents first column
item1.Text = Convert.ToString(StudentHouses.HouseNo);
//Add sub items starting with second column
item1.SubItems.Add((StudentHouses.AddressLine1));
item1.SubItems.Add((StudentHouses.AddressLine2));
item1.SubItems.Add((StudentHouses.AddressLine3));
//Add the items to the ListView.
listView1.Items.Add(item1);
}</pre>

BEGINNERINEED 16-Mar-11 18:03pm

no, all this is doing is adding the same data 10 times, but i think i am getting an idea, but thanks for sharing the code

Ed Nutting 17-Mar-11 3:09am

Yes of course it will because you need to change what SudentHouses refrences with each iteration. Something like (I presume) StudentHouses = AllStudentHouses[i]; Or something... it depends on how you have stored you list of student houses. And change the i < 10 to however many StudentHouses you have.

Sergey Alexandrovich Kryukov 16-Mar-11 17:49pm

OK, done, but -- no obligations, please see my disclaimer.
I don't have time for the detailed explanation, but you can ask a question.

Also, don't you think you should start formally accepting my available answers, otherwise this discussion can last forever..?

Thank you.
--SA

Sergey Alexandrovich Kryukov 16-Mar-11 18:05pm

[misplaced]

BEGINNERINEED 16-Mar-11 18:17pm

thanks for the help, its really appreciated, and i will keep an eye out for your article, and soon i will be back asking for your expertise once again.

Espen Harlinn 16-Mar-11 18:13pm

Nice and simple - 5ed!

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2011-03-16T11:47:00

Disclaimer:

This code posted "as is", on request by OP.
It is working and very well-tested but I cannot take responsibility for its value for the any purposes.
This is a code fragment from the demo application for my unpublished article "Dynamic Method Dispatcher" and is not related to the main topic of my article.

The only reason I post it in advance is that OP asked for it.

The purpose if this post is to give an idea of code design based on separation of data model from UI, not for explaining each declaration in any level of detail.

C#

using System;
using System.Windows.Forms;
using Time = System.DateTime;

//...

ListViewItem ShowCommon(
        Time time, ListView listView,
        MessageInfo info,
        string customData, bool autoResize) {
    ListViewItem item =
        new ListViewItem(TestRenderers[(int)CommonColumn.Time](ref time, ref info, customData, true));
    for (int index = 0; index < listView.Columns.Count - 1; index++)
        item.SubItems.Add(new ListViewItem.ListViewSubItem());
    for (
        CommonColumn index = (CommonColumn)1;
        index < (CommonColumn)(Enum.GetValues(typeof(CommonColumn)).Length - 1);
        index++) {
            item.SubItems[(int)index].Text =
                TestRenderers[(int)index](ref time, ref info, customData, true);
    } //loop
    item.SubItems[listView.Columns.Count - 1].Text = customData;
    listView.Items.Add(item);
    if (autoResize)
        AutoResize(listView);
    listView.EnsureVisible(item.Index);
    ShowStatus(ref time, ref info, customData);
    return item;
} //ShowCommon

This code represents general purpose presentation of a Windows message. It transparently passes the instance of the ListViewItem for adding data specific to a specialized ranges of message IDs, like keyboard, mouse, status, etc.

Pay attention that no immediate constants are used (except 0, 1 and null). All data is extracted from some enumeration type definitions and arrays based on those definitions.

On enumerations, please see my series of three articles:
Enumeration Types do not Enumerate! Working around .NET and Language Limitations[^]
Human-readable Enumeration Meta-data[^]
Enumeration-based Command Line Utility[^].

The most relevant is the first article in the series, and a bit of the second one. Even though my demo application (small part shown above) does not use any code from any of these three libraries, some ideas are shared.

—SA