i want to reverse all numbers but it just reverse the nlast one

Question

0.00/5 (No votes)

See more:

// reversenum.cpp : Defines the entry point for the console application.
//

#include "stdafx.h"
#include<iostream>
using namespace std ;

int main()
{

	int num[100] ;
    int j = 0 , k ;
    int number = 0 ;
    int temp  ;
    int a = 0 , i ;
	int n ;
	cout << "please enter the numbers of numbers that you want :" << endl ;
	cin >> n ;

	cout << "please enter the numbers " << endl ;
	for( int j = 0 ; j < n ; j++ ){
		cin >> num[j] ;

	temp = num[j] ;
   while( temp / 10 > 0 )
	{
	temp /= 10 ;
		a++ ;	
	}
   for( ; num[j] / 10 != 0 ; num[j] /= 10 , a-- )
     {
        k = num[j] % 10 ;
        for( i = 0 ; i < a ; i++ )
          {
             k*=10;
          }

         number=k+number;
		
     }
   
   number += num[j]%10 ;
		
   cout << number <<endl ;

	}
	  
	
	return 0;
}

it cannot clear the first number then put the next number ?

Posted 10-Apr-11 7:34am

yay hello

Updated 10-Apr-11 20:56pm

v3

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2011-04-10T07:50:00

Solution 1

The problem is that you use the same variable (num) for all the input numbers. Hence you may either

Use an array instead of a single variable

or

Perform the reversing operation in the same loop you use for getting the input number by the user.

:-)

Posted 10-Apr-11 7:50am

CPallini

Comments

Sergey Alexandrovich Kryukov 10-Apr-11 15:56pm

Well spotted, correct advice. My 5.
--SA

Sandeep Mewara · Accepted Answer · 2011-04-10T08:29:00

To be more clear:

for( int i = 0 ; i < n ; i++ )
    cin >>num ;

You are over-writing the inputs here. In num, only the last one remains.

What is being suggested is to use an array instead. Store all the inputs and then try to reverse them.

BTW, it looks like that you got this code to from somewhere that reverses a number. This observation is based on the return type of your reverse() method and the way you use it in Main().

In order to reverse all the numbers that are input and then print it out, you need to make the change to method return type too.

Espen Harlinn · Accepted Answer · 2011-04-10T08:58:00

Why make it complicated?

C++

#include<stdio.h>
#include <iostream>
#include <vector>
#include <algorithm>

using namespace std;

//----------------------------------------
int _tmain(int argc, _TCHAR* argv[])
{
    cout << "please don't write plz, and enter the numbers of numbers that you want:" << endl;

    vector<int> values;
    int count;
    cin >> count;

    int value;

    cout << "please don't write plz, and enter the numbers" << endl ;
    for( int i = 0 ; i < count ; i++ )
    {
        cin >> value;
        values.push_back(value);
    }

    for (vector<int>::reverse_iterator it = values.rbegin(); it != values.rend(); it++)
    {
        value = *it;
        cout << value << endl;
    }

    return 0;
}

Regards
Espen Harlinn

i want to reverse all numbers but it just reverse the nlast one

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0