copying column value from sql server in a string

Question

0.00/5 (No votes)

See more:

hi to all!

here i wrote a code to copy all column value in a string but its copying only first column value

C#

if (rdr.HasRows)
               {
                   StringBuilder sb = new StringBuilder();
                   string a;
                   while (rdr.Read())
                   {
                       sb.Append(((string)rdr["modname_vc"]).ToString());
                       sb.Append("\n");
                       a = sb.ToString();
                       for (int i = 0; i < module_name_menustrip.Length; i++)
                       {
                           module_name_menustrip[i] = a;
                           MessageBox.Show(module_name_menustrip[i]);
                           sb.Length = 0;
                           count1++;

                       }

                   }

can u please tell me whats the error

Posted 30-Jul-11 22:56pm

kami124

Updated 30-Jul-11 22:59pm

walterhevedeich

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Manas Bhardwaj · Answer 1 · 2011-07-30T23:51:00

Solution 3

Why don't you do this at SQL Server itself? Look here on how to concat column values in SQL.

Get Column values as comma seperated string [^]

Posted 30-Jul-11 23:51pm

Manas Bhardwaj

Comments

kami124 31-Jul-11 5:55am

ok, its clear now i have to add the string in menustrip

OriginalGriff · Answer 2 · 2011-07-30T23:13:00

I'm not exactly sure what you are trying to do here, your code doesn't make a lot of sense.
1) You have a loop, through all of the rows returned from your database.
2) You read the row value, and add it to the StringBuilder, along with a newline.
3) You then convert it to a string, and enter a new loop.
4) In this loop, you load all the elements of an array with the string, and kill the StringBuilder, by resetting the length.

Why have the StringBuilder at all? You code is the equivalent of:

C#

if (rdr.HasRows)
{
    while (rdr.Read())
    {
        for (int i = 0; i < module_name_menustrip.Length; i++)
        {
            module_name_menustrip[i] = ((string)rdr["modname_vc"]).ToString() + "\n";
            MessageBox.Show(module_name_menustrip[i]);
            count1++;
        }
    }

walterhevedeich · Answer 3 · 2011-07-30T23:13:00

Solution 2

You are only concatenating one column value, which is modname_vc. What you need to do is to loop to all the columns of your data reader and get their values.

Posted 30-Jul-11 23:13pm