delete in entity framework

Question

0.00/5 (No votes)

See more:

hi i use this code for delete records in entity framework(several record)

C#

var tag = from t in objLib.TagsField where t.Book_ID_FK == id select t;
         foreach (var t in tag)
         {
             objLib.TagsField.Context.DeleteObject(t);
             objLib.SaveChanges();
         }

how i delete it without use for each this code ( it Takes time!!)

Posted 19-Sep-11 5:06am

javad_r_85

Add a Solution

Comments

Sergey Alexandrovich Kryukov 19-Sep-11 11:12am

Why without "foreach"? How do you know that your performance leak is there?
Do you want to try exact same set of objects as in your sample but faster?
--SA

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2011-09-19T05:16:00

I see nothing wrong with foreach, but try to carry SaveChanges out of the loop. If you really have a performance leak related to foreach, it's rather in repeated SaveChanges. There is no need to repeat it for each object.

Try:

C#

foreach (var @object in tag)
   objLib.TagsField.Context.DeleteObject(@object);
objLib.SaveChanges();

—SA

kris444 · Answer 2 · 2011-09-19T15:53:00

Hi
EntityFramework has not provided any function that takes list of entities to delete...When you call DeleteObject it just marks that entity should be deleted on SaveChanges...

So even if there is a function in EF level like

DeleteObjects(IList<object> toBeDeleted)...it has to loop through each element to mark as deleted right?

If you are facing performance issue, this is not because you are using foreach, it is because you are calling SaveChanges in side foreach... I guess call to SaveChanges has to go through whole context to check what are the entities to be consider for update or delete..obviuosly this takes time right?

As SAKryukov mentioned it is better call SaveChanges in one-go.

Hope this helps you...

delete in entity framework

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0