Simple question about C#, SQL taking a Int format out

Question

0.00/5 (No votes)

See more:

C#

SqlCommand cmd = new SqlCommand("SELECT * FROM [t_memsch] where [m_memcode]='" + m_memcode_input.Text + "'", conn);
                SqlDataAdapter sda1 = new SqlDataAdapter(cmd);
                DataTable ds1 = new DataTable();

                sda1.Fill(ds1);     

DateTime date1 = Convert.ToDateTime(ds1.Rows[temp]["m_schdate"].ToString());
                        int session = ds1.Rows[temp]["m_schsession"].toInt16();

Any idea why i cant take the "m_schsession" out? A error is occurred.

It does now allow me to use toInt16(). Only toString() is allowed.

Posted 3-Jan-12 18:13pm

tomy_hkcg

Updated 3-Jan-12 18:20pm

v2

Add a Solution

2 solutions

Solution 2

Also note that you should never use literals in your SQL statements. Use SqlParameter[^] instead. That would help you with conversion related problem, protect against SQL injections etc.

For example consider what's happening if you enter "Some'data" to m_memcode_input.Text

Posted 3-Jan-12 19:31pm

Wendelius

Comments

tomy_hkcg 4-Jan-12 1:33am

Note dropped. thanks for reminding.

Wendelius 4-Jan-12 1:38am

You're welcome :)

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

virang_21 · Accepted Answer · 2012-01-03T18:20:00

Solution 1

C#

int session =Int32.Parse(ds1.Rows[temp]["m_schsession"].toString());

Make sure you don't have null values coming from database in m_schsession column and I assume that temp is an integer value representing row number.

Posted 3-Jan-12 18:20pm

virang_21

Comments

tomy_hkcg 4-Jan-12 0:21am

perfectly worked. thanks you