parametrised query for inserting values

Question

0.00/5 (No votes)

See more:

I was trying to insert values into acess database by parameterised method

private void button1_Click(object sender, EventArgs e)
           {
               if (validationcontrol())
               {


                   MessageBox.Show(cmbjobcode.SelectedValue.ToString());
                   OleDbConnection oleDbConnection1 = new System.Data.OleDb.OleDbConnection(connString);
                   oleDbConnection1.Open();
                   OleDbCommand oleDbCommand1 = new System.Data.OleDb.OleDbCommand("INSERT INTO quotationmastertable (quotationcode ,jobcode , jobpk , sillabordercharges , battabordercharges , driverpayment , rent , extra , total , discount , remark ,amount ) Values (?,?,?,?,?,?,?,?,?,?,?,?) ", oleDbConnection1);
                   oleDbCommand1.Parameters.Add(txtquotationno.Text);
                   oleDbCommand1.Parameters.Add(cmbjobcode.Text);
                   oleDbCommand1.Parameters.Add(cmbjobcode.SelectedValue);
                   oleDbCommand1.Parameters.Add(int.Parse(txtsilabordercharges.Text));
                   oleDbCommand1.Parameters.Add(int.Parse(txtbattacharges.Text));
                   oleDbCommand1.Parameters.Add(int.Parse(txtdriverpayment.Text));
                   oleDbCommand1.Parameters.Add(int.Parse(txtrent.Text));
                   oleDbCommand1.Parameters.Add(int.Parse(txtextra.Text));
                   oleDbCommand1.Parameters.Add(int.Parse(txttotal.Text));
                   oleDbCommand1.Parameters.Add(int.Parse(txtdiscount.Text));
                   oleDbCommand1.Parameters.Add(txtremark.Text);
                   oleDbCommand1.Parameters.Add(int.Parse(txtamount.Text));
                   oleDbCommand1.CommandType = CommandType.Text;
                   oleDbCommand1.ExecuteNonQuery();
                   oleDbConnection1.Close();
                   MessageBox.Show(txtquotationno.Text);

               }
           }

but I am getting exception at the first line itself

oleDbCommand1.Parameters.Add(txtquotationno.Text);
exception is

The OleDbParameterCollection only accepts non-null OleDbParameter type objects, not String objects.

I am new to programming. Can anyone help by pointing out my mistakes?

Posted 22-Feb-12 8:47am

SREENATH GANGA

Updated 22-Feb-12 10:28am

wizardzz

v2

Add a Solution

2 solutions

Solution 1

Of course. The exception message is quite informative, you should just follow it.

You need to understand that a parameter is not a parameter value. It is essentially a meta-data description of the parameter which helps the ADO.NET to process actual parameter value when you substitute the value in the parametrized query.

In this way, the method System.Data.OleDb.OleDbCommand.Parameters.Add expect the parameter of the type System.Data.OleDb.OleDbParameter. Please see:
http://msdn.microsoft.com/en-us/library/system.data.oledb.oledbcommand.parameters.aspx[^],
http://msdn.microsoft.com/en-us/library/system.data.oledb.oledbparameter.aspx[^].

You probably need to understand how it all works in principle. Please read:
http://msdn.microsoft.com/en-us/library/yy6y35y8.aspx[^].

—SA

Posted 22-Feb-12 8:58am

Sergey Alexandrovich Kryukov

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

AmitKumar89 · Accepted Answer · 2012-02-22T17:42:00

Hi there..
Try this.

C#

private void button1_Click(object sender, EventArgs e)
            {
                if (validationcontrol())
                {
    
    
                    MessageBox.Show(cmbjobcode.SelectedValue.ToString());
                    OleDbConnection oleDbConnection1 = new System.Data.OleDb.OleDbConnection(connString);
                    oleDbConnection1.Open();
                    OleDbCommand oleDbCommand1 = new System.Data.OleDb.OleDbCommand("INSERT INTO quotationmastertable (quotationcode ,jobcode , jobpk , sillabordercharges , battabordercharges , driverpayment , rent , extra , total , discount , remark ,amount ) Values(@quotationcode ,@jobcode , @jobpk , @sillabordercharges , @battabordercharges , @driverpayment , @rent , @extra , @total , @discount , @remark ,@amount ) ", oleDbConnection1);
                    oleDbCommand1.Parameters.Add("@quotationcode", txtquotationno.Text);
                    oleDbCommand1.Parameters.Add("@jobcode", cmbjobcode.Text);
                    oleDbCommand1.Parameters.Add("@jobpk", cmbjobcode.SelectedValue);
                    oleDbCommand1.Parameters.Add("@sillabordercharges", int.Parse(txtsilabordercharges.Text));
                    oleDbCommand1.Parameters.Add("@battabordercharges", int.Parse(txtbattacharges.Text));
                    oleDbCommand1.Parameters.Add("@driverpayment", int.Parse(txtdriverpayment.Text));
                    oleDbCommand1.Parameters.Add("@rent", int.Parse(txtrent.Text));
                    oleDbCommand1.Parameters.Add("@extra", int.Parse(txtextra.Text));
                    oleDbCommand1.Parameters.Add("@total", int.Parse(txttotal.Text));
                    oleDbCommand1.Parameters.Add("@discount", int.Parse(txtdiscount.Text));
                    oleDbCommand1.Parameters.Add("@remark", txtremark.Text);
                    oleDbCommand1.Parameters.Add("@amount", int.Parse(txtamount.Text));
                    oleDbCommand1.CommandType = CommandType.Text;
                    oleDbCommand1.ExecuteNonQuery();
                    oleDbConnection1.Close();
                    MessageBox.Show(txtquotationno.Text);
    
                }
            }