how to reduce the code

Question

0.00/5 (No votes)

See more:

C#

private void ReadFTPFile(string path)
        {
            ftp = new FTPOperations();
            string str = ftp.ReadFromFtp(mLTEODPath + path);
            string[] strArr = str.Split(',');
            Record pdata = new Record(strArr.ToList());
            List<reading> lst = pdata.GetEODReaings();
            GridView2.DataSource = lst;
            GridView2.DataBind();
            Label1.Text = path;
        }

C#

private void ReadFTPFile(string path)
        {
            ftp = new FTPOperations();
            string str = ftp.ReadFromFtp(mLTMeterPath + path);
            string[] strArr = str.Split(',');
            Record pdata = new Record(strArr.ToList());
            List<reading> lst = pdata.GetInstReaings();
            GridView2.DataSource = lst;
            GridView2.DataBind();
            label1.Text = path;
        }

how to reduce the above two methods..

Posted 18-Jul-12 0:10am

skpraveenkumar

Updated 18-Jul-12 0:13am

Pankaj Nikam

v2

Add a Solution

Comments

Pankaj Nikam 18-Jul-12 6:16am

What do you mean by Reduce? Do you want them to have less code? i.e. do want your code to be DRY? What are the variables mLTEODPath and mLTMeterPath, where do the come from?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

StianSandberg · Answer 1 · 2012-07-18T00:15:00

Solution 1

What do you mean by reduce code?

this: ?

C#

GridView2.DataSource = new Record(new FTPOperations().ReadFromFtp(mLTEODPath + path).Split(',').ToList()).GetEODReaings();
GridView2.DataBind();
Label1.Text = path;

Posted 18-Jul-12 0:15am

StianSandberg

vangapally Naveen Kumar · Answer 2 · 2012-07-18T00:33:00

hey write only one method like
in your code you are using 2 different paths for that you have to declare global string like

C#

string str=""
then assign the paths to this string
like
if (strlteo="mLTEODPath")
{
str="mLTEODPath ";
}
else if(strltm="mLTMeterPath ")
{
str="mLTMeterPath "
}

use str in below method

C#

private void ReadFTPFile(string path)
        {
            ftp = new FTPOperations();
            string str = ftp.ReadFromFtp(str+ path);
            string[] strArr = str.Split(',');
            Record pdata = new Record(strArr.ToList());
            List<reading> lst = pdata.GetInstReaings();
            GridView2.DataSource = lst;
            GridView2.DataBind();
            label1.Text = path;
        }