Why does this simplefunction fails? All td's content being overwritten

Question

0.00/5 (No votes)

See more:

so i got this functions that's supposed to remove classes from elements,and set their innterHTML to nothing,however i got a condition before that stats that if that elment contains a certain class skip the iteration,
this does preserve the class and doesn't remove it so this part does work correctly, however it still overwrites the innerHTML content to nothing , no idea why?

the function:

function removeHints(board, i, j) {
    var elms = getHint(board, i, j)
    for (var i = 0; i < elms.length; i++) {
        if (elms[i].classList.contains('show')) {
            continue
        }
        else {
            elms[i].classList.remove('hint')
            elms[i].innerHTML = ''
        }
    }
}

What I have tried:

i have no idea how to continue

Posted 24-Jan-20 9:48am

Member 14719507

Updated 24-Jan-20 9:59am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Answer 1 · 2020-01-24T10:00:00

You can get rid of the continue part since there is nothing else to do in that case anyway:

JavaScript

function removeHints(board, i, j) {
    var elms = getHint(board, i, j);
    for (var i = 0; i < elms.length; i++) {
        if (!elms[i].classList.contains('show')) {
            elms[i].classList.remove('hint');
            elms[i].innerHTML = '';
        }
    }
}