I am trying to insert a date of birth into a database

Question

0.00/5 (No votes)

See more:

i'm trying to insert a data from date of birth txtbox to database but it shows a error cannot convert varchar to datetime

What I have tried:

registration button code

C#

protected void Register_Click(object sender, EventArgs e)
{
btnSave_Click(dob.Text);
}

function btnsave_click code

C#

public void btnSave_Click(string dob)
{
   cmd.Parameters.Add(DataAccess.CreateParameter(cmd, "DateofBirth", DbType.String, dob));
}

and in my database i have declared dob as a datetime datatype.
above codes are only main codes

Posted 17-Mar-20 21:23pm

Member 14743579

Updated 17-Mar-20 22:43pm

Add a Solution

2 solutions

Solution 2

Inside of method btnSave_Click, you need to:
1. Open SqlConnection[^]
2. Create SqlCommand[^]
3. Add parameters[^] to the command
4. ExecuteNonQuery[^]

As OriginalGriff already wrote, you need to use proper data type: DateTime, instead of text (string).

C#

public void btnSave_Click(DateTime dob)
{
	int retVal = 0;
	using(SqlConnection connection = new SqlConnection("connection_string_here"))
	{
		connection.Open();
		using(SqlCommand cmd = new SqlCommand("command_text_here", connection))
		{
			cmd.Parameters.Add(DataAccess.CreateParameter(cmd, "DateofBirth", DbType.DateTime, dob));
			retVal = cmd.ExecuteNonQuery();
		}
 	}
	if(retVal>0)
	{
		//success
	}
	else
	{
		//error!
	}
}

Posted 17-Mar-20 22:43pm

Maciej Los

Updated 18-Mar-20 0:02am

v2

Comments

phil.o 18-Mar-20 4:53am

DbType.DateTime would be more suitable, wouldn't it?

Maciej Los 18-Mar-20 6:02am

Thanks for pointing that out. Copy-paste mistake ;)

Member 14743579 18-Mar-20 6:07am

i have also used this.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2020-03-17T21:53:00

Don't use text to pass a date to a DB: it relies on the user and the DB sharing a common culture, or the date may be misinterpretted. For example, is 01-02-03 1st Feb 2003 (Europe), 2nd Jan 2003 (USA), or 3rd Feb 2001 (ISO / Japan)?
Either use a Calendar control which provides a DateTime value directly, or use DatTime.TryParse to check and convert user input to DateTime, then pass the DateTime value to the DB directly via your parameter. Remember that users make mistakes when they enter anything and it's important to ensure that only valid inputs get to your DB.