Dynamically generate elements with different ids

Question

0.00/5 (No votes)

See more:

I have php file with this code

PHP

$html .=  "\n\t".
        '<label id="myID" class="radio" style="min-height:42px;">'.
        '<input type="radio" style="float:none;" name="'.$var.'" id="'.$var.'" value="'.$item->value.'" '.$checked.'>'.
        $img.
        '<span style="margin-left: 10px;">'.JText::_($item->text).'</span>'.
        '</label>';
}
$html .= "\n";
return $html;

This code dynamically generates label tags. The label tags have id = myID, but I need to make different id for each label element. How can I reach that?

What I have tried:

I have tried to add increment but it doesn't work for me. Also I have tried to use the loop 'for'. And it works not correctly. I am new to php and I don't know how to do it. I will be appreciate for any help.

PHP

$idlist = array("ida", "idb", "idc");
     foreach($idlist as $id){
     $html .=  "\n\t".

          '<label id="' . $id . '" class="radio" style="min-height:42px;">'. "\n".

           '<input type="radio" style="float:none;" name="'.$var.'" id="'.$var.'" value="'.$item->value.'" '.$checked.'>'.
           $img.
           '<span style="margin-left: 10px;">'.JText::_($item->text).'</span>'.

             '</label>';

     }

   }

   $html .= "\n";
   return $html;

Posted 22-Aug-20 21:44pm

Member 14920672

Updated 23-Aug-20 3:41am

Patrice T

v4

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2020-08-22T22:20:00

Solution 1

A simple PHP loop that increments the value of $id:

PHP

$idlist = array("ida", "idb", "idc");
foreach($idlist as $id){
    echo '<label id="' . $id . '" class="radio" style="min-height:42px;">' . "\n";
}

Or a number counting alternative:

PHP

$num = 1;
while($num <= 3){
    echo '<label id="id' . $num . '" class="radio" style="min-height:42px;">' . "\n";
$num += 1;
}

See also PHP Tutorial[^]

Posted 22-Aug-20 22:20pm

Richard MacCutchan

Updated 22-Aug-20 22:50pm

v3

Comments

Member 14920672 23-Aug-20 5:29am

Thank you for the solution. But when I use your options I have got the error "syntax error, unexpected 'echo' (T_ECHO)"

This is due to this line $html .= "\n\t".

Richard MacCutchan 23-Aug-20 5:34am

The echo statement was just to illustrate the results in a test. You do not need it in your own code, just add the variable items in the places that I have shown.

Member 14920672 23-Aug-20 6:31am

I removed the "echo" and now payment elements in a browser are not showing. I see these label tags with correct IDs in DEV dashboard. But in browser there is empty place. What is wrong?

Richard MacCutchan 23-Aug-20 7:57am

I do not know what you are doing; if you are just copying my lines of code without adjusting them to fit your requirements then it probably will not work. Please use the Improve question link above, and add the exact code that you are using, so I can see it.

Member 14920672 23-Aug-20 8:13am

I inserted the part of code, please check it.

Richard MacCutchan 23-Aug-20 8:54am

Look at the following line:

          '<label id="' . $id . '" class="radio" style="min-height:42px;">'. "\n";

You have a semi-colon at the end, but it should have a dot so it continues on the next line.

Please do not just copy lines of code without examining and modifying them to make sure they fit correctly with what you are trying to do.

Member 14920672 23-Aug-20 9:30am

Now a browser is rendering 3 identical payment methods instead one. Please see the photo
https://drive.google.com/file/d/1uKJzMlDY9ivoE1nvbrchWwwD30ItqfFX/view

Richard MacCutchan 23-Aug-20 9:44am

Sorry, I don't know what you mean by that. And your Google drive link is not accessible. Are you varying all the other items that need to be different for each id?

Member 14920672 23-Aug-20 12:10pm

I try to explain. I have 3 payment methods. Bank transfer, PayPal and Skrill. But now I have 9 methods. 3 icons of Bank transfer, 3 icons of PayPal and 3 icons of Skrill. Try to open this link https://drive.google.com/file/d/1uKJzMlDY9ivoE1nvbrchWwwD30ItqfFX/view?usp=sharing

Richard MacCutchan 23-Aug-20 12:29pm

That link still does not work.

However, the issue is the same as I have already shown you. You need to create arrays for each item that you want to add to your HTML. Alternatively create functions which will return the appropriate items. If you really do not understand how to address arrays in PHP then go to the tutorial page that I already gave you the link to, and also PHP: Arrays - Manual[^].

But you are not going to learn PHP properly just by posting questions here.

Member 14920672 24-Aug-20 6:21am

Actually I am not learning php at this moment. I am creating a website on Joomla CMS and I need to get a solution of the issue. Do you mean, I need to create arrays for these elements and ?

Richard MacCutchan 24-Aug-20 6:25am

Sorry, I have no experience of Joomla so cannot advise what is the best way to address this issue. I suggest you try the support page at https://www.joomla.org/[^].

Member 14920672 24-Aug-20 6:32am

I am asking for help on this site, because I had asked at Joomla support before. Do you mean, I need to create arrays for these elements

<input>

and

<span>

?

Richard MacCutchan 24-Aug-20 6:36am

I have no idea, as I do not know what you are trying to do. One of the reasons I told you to study PHP is because you are trying to write code without understanding what your problem is: a sure recipe for disaster.

Member 14920672 24-Aug-20 6:56am

Very strange thing. You wrote me yesterday "You need to create arrays for each item that you want to add to your HTML..." And now you are talking that you have no idea. It's a shame you can't help me.

Richard MacCutchan 24-Aug-20 7:13am

I was guessing because it was not clear what you are trying to do. And looking at the code you do have, and some of your later comments, I do not think it is that simple. Maybe if you open a new question with a clearer explanation of what you are trying to do we can offer some useful advice.