Hello , need to correct the programe and find mistake? In C language! ! !

Question

1.00/5 (1 vote)

See more:

I want to write a programe of array with n inputs so that it can find sum of even numbers and product of odd numbers and aslo it should display no odd / even numbers if there they not entered in array. I WRITE THE PROGRAME AS YOU CAN SEE DOWN, BUT WHEN I RUN IT I AM GETTING """""Process returned -1073741571 (0xC00000FD) execution time : 4.390 s
Press any key to continue"""""

What I have tried:

#include<stdio.h>
int main()
{
    int n,a[n],i,sum=0,product=1,cont=0,con_t=0;
    printf("ENTERNO OF ELEMENTS:");
    scanf("%d",&n);
    printf("ENTER THE NUMBERS:\n");
    for(i=0;i<n;i++)

    {
        printf("a[%d]:",i);
        scanf("%d",&a[i]);

    }
    for(i=0;i<n;i++)
    {

        if (a[i]%2==0)

           {
             sum+=a[i];

           }
        else

            {
                product*=a[i];


            }
    }

    for (i=0;i<n;i++)

    {
        if (a[i]%2==0)

        {
          con_t++;
        }

        else

        {
           cont++;
        }

    }

    if (con_t=0)

    {
        printf(" no even numbers");

    }
    else
    {
    printf("sum of all even numbers= %d\n",sum);
    }


 if (cont==0)
        {
    printf( " no odd numbers ");
        }
        else
        {


  printf("product  of all odd numbers = %d",product);

        }

}

Posted 12-Nov-21 1:28am

Member 15428130

Updated 13-Nov-21 1:15am

v2

Add a Solution

Comments

CHill60 12-Nov-21 7:39am

And - what is your question?

When I run your code with 1,2,3,4 I get answer 6 and 3 as expected.
What problem do you think there is?

CHill60 12-Nov-21 7:53am

Please do not scream at me

Member 15428130 12-Nov-21 8:00am

I AM EXCITED DUDE , IT WAS MY OWN CODE AS A LEARNER YOU SAID IT WORKING SO I GOT EXCITED!!!

Dave Kreskowiak 12-Nov-21 8:18am

Yeah, typing in all caps is yelling at people.

Member 15428130 12-Nov-21 9:42am

oh, I don't about this, I thought it was a highlight to see that's why I wrote in it, sorry dude if you feel bad.

Richard Deeming 12-Nov-21 9:42am

0xC00000FD is a "stack overflow" exception, which usually occurs when you have infinite or excessive recursion. There's nothing obvious in the code you've shown which would cause that.

Member 15428130 12-Nov-21 9:46am

ok, but when i perform in my compiler I am getting 0xC00000FD, as you mentioned There's nothing obvious in the code, then why I am getting this, any idea, coder?

jeron1 12-Nov-21 10:16am

Does this code even compile? You're trying to allocate an array of unknown size 'n'

int n,a[n],i,sum=0,product=1,cont=0,con_t=0; // n is not defined at this point

Member 15428130 12-Nov-21 10:27am

see i used scanf to give its size " n".

Richard MacCutchan 12-Nov-21 10:36am

But that is after it has been declared so it will not even compile. So whatever code you are running it is not the version that you have posted here.

jeron1 12-Nov-21 10:43am

You get n after declaring the array, the size is unknown and memory is not allocated.

Generally when allocating an unknown sized array,

int n;
scanf("%d", &n); // get n
// validate n
int* a = (int *) malloc(n * sizeof(int)); //allocate memory for the array

Also, using meaningful variable names help in the long run.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2021-11-12T01:53:00

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:

Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16

Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:

int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

CHill60 · Answer 2 · 2021-11-12T05:09:00

As you will see from the comments, your problem is in the way you have declared the array a[n]. The behaviour of the program cannot be predicted.

You could use the technique suggested by @jeron1

Or you could dynamically allocate the memory once you know the value of n - e.g. C dynamic memory allocation - Wikipedia[^]

But my advice, given your current level of expertise would be to define a maximum size for n and just declare the array to that maximum size. Then you can concentrate on the real point of the exercise.

Another observation - you don't need to loop through the numbers twice. Increment your counter in the same statement block as calculating the sum or product e.g.

#include<stdio.h>
int main()
{
    int n = 51,a[50],i;
    long sum = 0, product=1;
    int cont=0,con_t=0; // count of odd / even
    while (n > 50 || n < 1)
    {
        printf("ENTER NO OF ELEMENTS (Max 50):\n");
        scanf("%d",&n);
    };
    
    printf("ENTER THE NUMBERS:\n");
    for(i=0;i<n;i++)
    {
        printf("a[%d]:\n",i);
        scanf("%d",&a[i]);
    }

    for(i=0;i<n;i++)
    {
        if (a[i]%2==0)
        {
            // Even so sum
            sum+=a[i];
            con_t++; // increment count of even 
        }
        else
        {
            // odd so get product
            product*=a[i];
            cont++;  // increment count of odd
        }
    }
    
    if (con_t=0)
    {
        printf(" no even numbers\n");
    }
    else
    {
        printf("sum of all even numbers= %d\n",sum);
    }

    if (cont==0)
    {
        printf( " no odd numbers\n");
    }
    else
    {
        printf("product  of all odd numbers = %d\n",product);
    }
}

Patrice T · Answer 3 · 2021-11-13T01:15:00

Quote:
Process returned -1073741571 (0xC00000FD) execution time : 4.390 s

Errors you have in code:

C++

#include<stdio.h>
int main() { // Because of the int here
    ....

    return 0; // the program have to end with a return and a value you choose
}

you should also replace

C++

if (con_t=0)

with

C++

if (con_t==0)

-----
Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

1.11 — Debugging your program (stepping and breakpoints) | Learn C++[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

Hello , need to correct the programe and find mistake? In C language! ! !

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0