Syntax error in update statement

Question

0.00/5 (No votes)

See more:

I am using ms access and vb.net, and I'm having the problem in update button error

The error is : syntax error

The code is:

VB

Private Sub btnActualizar_Click(sender As Object, e As EventArgs) Handles btnActualizar.Click
        miConeccion.Open()
        Dim str As String
        str = "UPDATE [tblClientes] set Nombre = '" & txtNombre.Text & "', Apellido '" _
            & txtApe.Text & "' , Seguro Social = '" & txtSS.Text & "', ZipCode = '" & txtZipCode.Text _
            & "', Ciudad " & txtCiudad.Text & "', Telefono = '" & txtNumT.Text _
            & " Where [NumId] = " & txtNumID.Text & ""
        Dim comando As OleDbCommand = New OleDbCommand(str, miConeccion)
        Try

            comando.ExecuteNonQuery()

        Catch ex As Exception
            MsgBox(ex.Message)
        End Try
        miConeccion.Close()
    End Sub

Thank You

Posted 23-Feb-13 21:48pm

Joel Sosa Rivera

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-02-23T21:53:00

Equals sign and spaces and quotes, my friend. Equals sign and spaces and quotes...

VB

str = "UPDATE [tblClientes] set Nombre = '" & txtNombre.Text & "', Apellido '" _
    & txtApe.Text & "' , Seguro Social = '" & txtSS.Text & "', ZipCode = '" & txtZipCode.Text _
    & "', Ciudad " & txtCiudad.Text & "', Telefono = '" & txtNumT.Text _
    & " Where [NumId] = " & txtNumID.Text & ""

Becomes

VB

str = "UPDATE [tblClientes] set Nombre = '" & txtNombre.Text & "', Apellido = '" _
    & txtApe.Text & "' , [Seguro Social] = '" & txtSS.Text & "', ZipCode = '" & txtZipCode.Text _
    & "', Ciudad ='" & txtCiudad.Text & "', Telefono = '" & txtNumT.Text _
    & "' Where [NumId] = " & txtNumID.Text & ""

But don't do it like that!
Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

"Thanks can you refer me a link to learn how to Parametrized the queries instead? Thank You"

Simple (but a cut down version because I'm feeling lazy):

VB

str = "UPDATE tblClientes SET Nombre = @NOM WHERE NumId=@NI"
Dim comando As OleDbCommand = New OleDbCommand(str, miConeccion)
commando.Parameters.AddWithValue("@NOM", txtNombre.Text)
commando.Parameters.AddWithValue("@NI" txtNumID.Text)

You can see that it is easier to read, and it means that I can't destroy your database by typing in the text boxes! :laugh:

Look at Parameters.AddWithValue on MSDN and it will explain more - there are versions for SqlCommand, MySQlCommand, OldbCommand, etc.