problem with the loop while

Question

1.44/5 (2 votes)

See more:

hi,
i have this function that doesnt seem to work right,
i want to make a shape change the colour when i click on a button,
i click the first time ,the colour has to stay pink until i click another time so it will change to black.

but after the first click the program stop responding at all,and i can't click any more.

C#

int on=0;
private void start_Click(object sender, EventArgs e)
        {
            if (on == 0)
                on = 1;
            else
                on = 0;
            //MessageBox.Show(on.ToString());
            while (on==1)
            {
                ind1.FillColor = System.Drawing.Color.Pink;
            }
            ind1.FillColor = System.Drawing.Color.Black;
            //colour_adjustement("10.175.22.234");
        }

thank you for your help

Posted 20-Mar-13 6:51am

Member 9870058

Add a Solution

3 solutions

Solution 2

You don't need a while loop here.

C#

int on=0;

private void start_Click(object sender, EventArgs e)
{
   if (on == 0)
   {
      on = 1;
      ind1.FillColor = System.Drawing.Color.Black;
   }
   else
   {
      on = 0;
      //MessageBox.Show(on.ToString());
      ind1.FillColor = System.Drawing.Color.Pink;
   }
}

Why do you want to use a while loop here ?

Posted 20-Mar-13 7:02am

phil.o

Comments

Member 9870058 20-Mar-13 17:26pm

the problem is that's not the program that i want to realise,it's just a test.
Because in my program i would need a loop,the actions according to the test have to be repeated until the user click on start again.
i want to get a value every 5 sec and according to it change the colour of a button.
thanks for replying

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhinav S · Accepted Answer · 2013-03-20T07:01:00

Solution 1

while (on==1)
{
     ind1.FillColor = System.Drawing.Color.Pink;
}

This is a very bad idea.
You have put yourself into an infinite loop and thus the entire program hangs.

I guess you want to use an if condition instead of a while loop.

Posted 20-Mar-13 7:01am

Abhinav S

Comments

fjdiewornncalwe 20-Mar-13 16:37pm

+5. Absolutely.

Abhinav S 20-Mar-13 22:57pm

Thank you.

Member 9870058 20-Mar-13 17:26pm

the problem is that's not the program that i want to realise,it's just a test.
Because in my program i would need a loop,the actions according to the test have to be repeated until the user click on start again.
i want to get a value every 5 sec and according to it change the colour of a button.
thanks for replying

Abhinav S 20-Mar-13 22:58pm

Then use animations if you are using WPF or a Timer with a 5 sec interval to flash a color change.
While Loop is not the solution for this problem.

Member 9870058 21-Mar-13 10:15am

could you please clearify this to me.Because i am a real begginner in this type of develloping.
thanks

José Amílcar Casimiro · Accepted Answer · 2013-03-20T07:05:00

Solution 3

You're getting an infinite loop.

C#

while (on==1)
{
        ind1.FillColor = System.Drawing.Color.Pink;
        //your program stays in a loop here.
}

Your code is very ugly, try this:

C#

bool on=false;

private void start_Click(object sender, EventArgs e)
{
            on = !on;
            ind1.FillColor = 
                 (on ? System.Drawing.Color.Pink : System.Drawing.Color.Black);
            //colour_adjustement("10.175.22.234");
}

Good luck.

Posted 20-Mar-13 7:05am

José Amílcar Casimiro

Comments

Member 9870058 20-Mar-13 17:25pm

the problem is that's not the program that i want to realise,it's just a test.
Because in my program i would need a loop,the actions according to the test have to be repeated until the user click on start again.
i want to get a value every 5 sec and according to it change the colour of a button.
thanks for replying

José Amílcar Casimiro 20-Mar-13 17:32pm

Use a Timer object to launch the task every 5 seconds.

MuhammadUSman1 21-Mar-13 0:04am

Dear [José Amílcar Ferreira Casimiro] i have posted one question on CP i Need Your Help about my Question.
Question Link is

http://www.codeproject.com/Questions/564735/Openpluswebpluspage-2cplusloginplusandplusthenplus

I know it is not right place to ask something but. I like your way of coding. So if possible then please Help.

Thanks.

José Amílcar Casimiro 21-Mar-13 5:53am

I can see that your problem is solved. keep coding.

Member 9870058 21-Mar-13 10:18am

i look at that,thank you very much for your help.

MuhammadUSman1 21-Mar-13 23:51pm

Thanks Dear.

Member 9870058 27-Mar-13 8:13am

my problem is solved thanks to you.
timer is the solution i was looking for.