How to save gridview data to a database which has dropdown lists.

Question

4.00/5 (1 vote)

See more:

Hello,
I have a grid view, which has 5 columns. First 2 columns are student roll no,and name other 3 columns have dropdown lists( created using template). I am displaying rollno and student name from a database table. After displaying this, If a user changes these dropdownlist and want to save to another table, I am getting error. Kindly have a look at my code.

C#

int id;
            string a1,a2,a3;
            int rowIndex = 0;
            
           foreach (GridViewRow g1 in GridView1.Rows)
            {
                
                DropDownList box2 = (DropDownList)GridView1.Rows[rowIndex].Cells[0].FindControl("dd1");
                DropDownList box3 = (DropDownList)GridView1.Rows[rowIndex].Cells[0].FindControl("dd2");
                DropDownList box4 = (DropDownList)GridView1.Rows[rowIndex].Cells[0].FindControl("dd3");
                rowIndex++;
                id = int.Parse(g1.Cells[1].Text); I am getting error on this line
                a1 = box2.SelectedValue.ToString();
                a2 = box3.SelectedValue.ToString();
                a3 = box4.SelectedValue.ToString();
                SqlCommand cmd = new SqlCommand(@"INSERT INTO [dbo].[class7]([IdNo],[SectionNo],[Date],[math],[science],[social]) VALUES
           (" + id + "," + sect + ",getdate(),'" + a1 + "','" + a2 + "','" + a3 + "')", con);
                cmd.ExecuteNonQuery();

            }

Is this is the best approach to store data from gridview, or there any other way is available??

Thanks in advance for taking pain for me.

Posted 21-Apr-13 3:07am

2012programmer

Updated 21-Apr-13 3:16am

Sandeep Mewara

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

traciray · Answer 1 · 2013-04-21T08:10:00

I have a suggestion regarding your error. You mention the error is coming from the following line:

C#

id = int.Parse(g1.Cells[1].Text);

Maybe change the Parse to a TryParse to catch any data errors, like the following:

C#

if(int.TryParse(g1.Cells[1].Text, out id))
{ 
    a1 = box2.SelectedValue.ToString();
    a2 = box3.SelectedValue.ToString();
    a3 = box4.SelectedValue.ToString();
    SqlCommand cmd = new SqlCommand(@"INSERT INTO [dbo].[class7]([IdNo],
        [SectionNo],[Date],[math],[science],[social]) VALUES
        (" + id + "," + sect + ",getdate(),'" + a1 + "','" + a2 + "','"  
        + a3 + "')", con);
    cmd.ExecuteNonQuery();
}

The above should keep the application from crashing when a non-integer is put into that cell due to user error. As for the broader issue of storing the data from the grid view, it depends on your needs. For best performance, you might think about working with a local copy of the data rather than making separate trips to the database for each row (i.e., set the data source of the gridview equal to the local copy, then update the database with the local data as needed). The local copy could use EntityFramework, LinqToSql, ADO.NET (DataSet, DataTable, etc.), or even a simple collection (e.g., a generic List of StudentInfo, a class containing the info you want to keep).

However, if the application is just for internal use, for instance, and you don't have major database issues, then there may be no need to make any changes. It all depends on your needs.

Best of luck!