How to solve error in bool function

Question

0.00/5 (No votes)

See more:

Hi,

I am trying to write bool function as shown below

C#

public bool retunPGN(int m,CANBusDetails busOneDetails)
        {

            List<PGNsegmentTxMap> PGNsegmentMapList123 = new List<PGNsegmentTxMap>();

            PGNsegmentMapList123 = ReadDatabase();

            for (int i = 0; i < PGNsegmentMapList123.Count; i++)
            {
                if ((PGNsegmentMapList123[i].PGN == busOneDetails.CANMessageDetailsList[m].HexMessageId)
                    && (PGNsegmentMapList123[i].segmentTx == select1))

                    return true;
                else
                    return false;
            }
        }

Error:
'SCANLA.GatewayMsgIDs.retunPGN(int, SCANLA.Common.CANBusDetails)': not all code paths return a value

Can anyone help me in solving this problem??

Thanks
John

Posted 10-Feb-14 3:01am

Member 10408451

Add a Solution

Comments

Richard MacCutchan 10-Feb-14 9:09am

Your loop will only ever execute once, which means you ignore all potential true conditions further down your list. You should move the false return out of the loop and make it the default for when all items in the list have been tested but no item matches.

3 solutions

Solution 2

It is possible that for will never hit - no members in your list.
In that case there is a code-path that does not do return - either true or false...

In simple words, add return(false) or return(true) just after the closing of the for...

Posted 10-Feb-14 3:09am

Kornfeld Eliyahu Peter

Solution 3

If PGNsegmentMapList123.Count is equal to zero, then no return statement will be executed. Resolve this by putting return false; at the end of the subroutine.

More importantly, the if statement will only be executed for the first item in PGNsegmentMapList123 since you are executing a return whether the if statement is true or false.

Posted 10-Feb-14 3:11am

Mike Meinz

Updated 10-Feb-14 3:12am

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Karthik_Mahalingam · Accepted Answer · 2014-02-10T03:08:00

Try this code..
Its no use of reurning from the loop values as it will return only the first value in the collection. anyhow this will help you from that bool return issue.

C#

public bool retunPGN(int m, CANBusDetails busOneDetails)
        {
            bool flag = false;
            List<PGNsegmentTxMap> PGNsegmentMapList123 = new List<PGNsegmentTxMap>();

            PGNsegmentMapList123 = ReadDatabase();

            for (int i = 0; i < PGNsegmentMapList123.Count; i++)
            {
                if ((PGNsegmentMapList123[i].PGN == busOneDetails.CANMessageDetailsList[m].HexMessageId)
                    && (PGNsegmentMapList123[i].segmentTx == select1))
                    flag = true;
                break;

            }
            return flag;

        }