need help with random

Question

0.00/5 (No votes)

See more:

Hey there.. i am currently working on a program that should be generating 3 random numbers and post it on som labels.

the problem is that sometimes it generates 3 numbers where 2 or all 3 of them are equal. How can i avoid that?

Here is my code:

public static void newrand(Label num1, Label num2, Label num3)
       {
           Random rnd = new Random();
           int[] randomnumber = new int[3];
           for (int counter = 0; counter < 3; counter++)
           {
               randomnumber[counter] = rnd.Next(min, max);
           }
           if (randomnumber[0] != randomnumber[1])
           {
               if (randomnumber[0] != randomnumber[2])
               {
                   num1.Text = randomnumber[0].ToString();
               }
               else
               {
                   Random rnd1 = new Random();
                   int i = randomnumber[0];
                   while (i == randomnumber[0] && i == randomnumber[1] && i == randomnumber[2])
                   {
                       i = rnd1.Next(min, max);
                   }
                   num1.Text = randomnumber[0].ToString();
               }


               if (randomnumber[1] != randomnumber[0])
               {
                   if (randomnumber[1] != randomnumber[2])
                   {
                       num2.Text = randomnumber[1].ToString();
                   }
                   else
                   {
                       Random rnd1 = new Random();
                       int i = randomnumber[1];
                      while (i == randomnumber[1] && i == randomnumber[0] && i == randomnumber[2]);

                       {
                           i = rnd1.Next(min, max + 1);
                       }  num2.Text = randomnumber[1].ToString();
                   }
                   if (randomnumber[2] != randomnumber[0])
                   {
                       if (randomnumber[2] != randomnumber[1])
                       {
                           num3.Text = randomnumber[2].ToString();
                       }
                       else
                       {
                           Random rnd1 = new Random();
                           int i = randomnumber[2];
                           while (i == randomnumber[1] && i == randomnumber[0] && i == randomnumber[2])
                           {
                               i = rnd1.Next(min, max);
                           }
                           num3.Text = randomnumber[2].ToString();
                       }

                   }
               }
           }
       }

Posted 14-Jun-10 8:18am

utunity

Updated 14-Jun-10 10:07am

#realJSOP

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Hans Dietrich · Answer 1 · 2010-06-14T08:31:00

If you look at what MSDN says about Random() here: http://msdn.microsoft.com/en-us/library/system.random.aspx[^] you will see that it ialks about exactly this case: "that two Random objects that are instantiated in close succession generate an identical series of random numbers."

The solution is to use one Random() object to generate multiple numbers.

See the MSDN page for more info.

Abhishek Sur · Answer 2 · 2010-06-14T10:49:00

Random numbers generated using System.Random depends on the seed value you pass while creating the object.

So if you are creating 2 random object which you want to act differently you can pass the seed value different and you will see the output.

Other than that, the Default constructor of random calls
GetTickCount API call which returns the number of milliseconds passed after the system starts up.
http://msdn.microsoft.com/en-us/library/ms724408%28VS.85%29.aspx[^]

So if you create two objects in succession, it might be created on same millisecond interval, and hence will give you the same output.

I hope this clears you totally.

:rose:

CPallini · Answer 3 · 2010-06-14T10:49:00

Solution 3

As already suggested, don't use multiple instances of Random that way.
To avoid testing for duplicates, have a look at my tip: "Random extraction of 5 cards from a deck" [^](you know duplicated cards would be unpleasant). It is C++, but it is the algo that matters.
:)

Posted 14-Jun-10 10:49am

CPallini

Updated 14-Jun-10 10:50am

v2

need help with random

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0