incorrect syntax near 's'

Question

0.00/5 (No votes)

See more:

i'm getting error Incorrect syntax near s'

SQL

da = new SqlDataAdapter("insert into rsa_addtocart(UserId,productid,productname,ProductImage,price,qty,totalcost,cdate)values(" + Convert.ToInt32(Session["users"].ToString()) + "," + Convert.ToInt32(ds.Tables[0].Rows[0][0].ToString()) + ",'" + ds.Tables[0].Rows[0][1].ToString() + "','" + ds.Tables[0].Rows[0][3].ToString() + "'," + Convert.ToDecimal(ds.Tables[0].Rows[0][2].ToString()) + ",1," + Convert.ToDecimal(ds.Tables[0].Rows[0][2].ToString()) + ",getdate())", con);
                   da.SelectCommand.ExecuteNonQuery();

If product name is without apostrophe i'm not getting any error but with apostrophe it throws an exception so tried to use the parameterized queries but don't know how to get values in parameters for ProductImage

ProductImage,ds.Tables[0].Rows[0][3].ToString()

please help me to solve this.

Posted 4-Jun-15 1:17am

kwelpooh

Updated 4-Jun-15 1:18am

v2

Add a Solution

Comments

ConnectingKamlesh 4-Jun-15 7:40am

Try replacing the apostrophe with double apostrophe,

ds.Tables[0].Rows[0][1].ToString().Replace("'","''");

F-ES Sitecore 4-Jun-15 7:41am

Use parameterised queries. Google "parameterised queries ado.net"

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-06-04T01:43:00

Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

The chances are that that will cure your problem at the same time.

C#

using (SqlCommand cmd = new SqlCommand("insert into rsa_addtocart(UserId,productid,productname,ProductImage,price,qty,totalcost,cdate)values(@UID, @PID, @PN, @PI, @PR, @QTY, @TC, GETDATE())", con))
    {
    cmd.Parameters.AddWithValue("@UID", Convert.ToInt32(Session["users"]));
    cmd.Parameters.AddWithValue("@PID", Convert.ToInt32(ds.Tables[0].Rows[0][0]);
    cmd.Parameters.AddWithValue("@PN", ds.Tables[0].Rows[0][1]);
    cmd.Parameters.AddWithValue("@PI", ds.Tables[0].Rows[0][3]);
    cmd.Parameters.AddWithValue("@PR", Convert.ToDecimal(ds.Tables[0].Rows[0][2]);
    cmd.Parameters.AddWithValue("@QTY", 1);
    cmd.Parameters.AddWithValue("@TC", Convert.ToDecimal(ds.Tables[0].Rows[0][2]);
    cmd.ExecuteNonQuery();
    }

[edit]Missed that hard coded value![/edit]

Richard Deeming · Accepted Answer · 2015-06-04T01:47:00

Your code is vulnerable to SQL Injection[^].

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

C#

using (var command = new SqlCommand("insert into rsa_addtocart (UserId, productid, productname, ProductImage, price, qty, totalcost, cdate) values (@UserId, @productid, @productname, @ProductImage, @price, @qty, @totalcost, @cdate)", con))
{
    command.Parameters.AddWithValue("@UserId", Session["users"]);
    command.Parameters.AddWithValue("@productid", ds.Tables[0].Rows[0][0]);
    command.Parameters.AddWithValue("@productname", ds.Tables[0].Rows[0][1]);
    command.Parameters.AddWithValue("@ProductImage", ds.Tables[0].Rows[0][3]);
    command.Parameters.AddWithValue("@price", ds.Tables[0].Rows[0][2]);
    command.Parameters.AddWithValue("@qty", 1);
    command.Parameters.AddWithValue("@totalcost", ds.Tables[0].Rows[0][2]);
    command.Parameters.AddWithValue("@cdate", DateTime.Now);
    
    if (con.State != ConnectionState.Open)
    {
        con.Open();
        try
        {
            command.ExecuteNonQuery();
        }
        finally
        {
           con.Close();
        }
    }
    else
    {
        command.ExecuteNonQuery();
    }
}

incorrect syntax near 's'

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0