Click here to Skip to main content
14,933,535 members
Articles / Web Development / ASP.NET
Posted 5 Aug 2010

Tagged as


6 bookmarked

Probable leak while using SqlDataReader in ADO.NET

Rate me:
Please Sign up or sign in to vote.
5.00/5 (6 votes)
5 Aug 2010CPOL
Probable leak while using SqlDataReader in ADO.NET
I was doing a bit of exploration on Connections with doing this exercise i realized that when using CloseConnection along with the reader i was under the impression that it closes by itself but actually it wont close the connection.

I had pasted the code sample below which i executed during the test.

while (true)
    SqlConnection objConnection = default(SqlConnection);
    objConnection = new SqlConnection(@"Integrated Security=SSPI;Persist Security Info=True;Initial Catalog=Northwind;Data Source=.;Max Pool Size=1");
    SqlCommand objCommand = new SqlCommand("Select * from customers", objConnection);
    SqlDataReader reader = objCommand.ExecuteReader(System.Data.CommandBehavior.CloseConnection);
    while (reader.Read())

So the tip is either create the sqlconnection object by using - using syntax (which ensures that it Disposes connection Object) or after the execution before leaving make a call to explicitly close the connection.

This ensures that connection will be closed for sure. Hence no leak

I hope this helps!.



This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)


About the Author

Vinayaka Krishna Shenoy
Architect MindTree Ltd
India India
Motivated achiever who guides organizations in applying technology to business settings, provides added value, and creates project deliverables in a timely manner. An experienced Technical Consultant, have successfully led large project teams of more than 20 people from requirements gathering to implementation and support using C#, .NET ,ADO.NET, ADO.NET Entity Framework,ASP.NET,ASP.NET MVC, WCF and SQL Server.

Comments and Discussions

GeneralReason for my vote of 5 yeah this is perfect! Pin
manjeeet7-Aug-10 1:14
Membermanjeeet7-Aug-10 1:14 
GeneralReason for my vote of 5 Good one, I am surprised, thanks for... Pin
vinayakshenoy2000@gmail.com5-Aug-10 20:45
Membervinayakshenoy2000@gmail.com5-Aug-10 20:45 
GeneralConfusion with sample code attached Pin
r verma11-Aug-10 20:22
Memberr verma11-Aug-10 20:22 
GeneralRe: Confusion with sample code attached Pin
Vinayaka Krishna Shenoy11-Aug-10 21:16
MemberVinayaka Krishna Shenoy11-Aug-10 21:16 
GeneralRe: Confusion with sample code attached Pin
r verma11-Aug-10 21:47
Memberr verma11-Aug-10 21:47 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.