Random binary number generator

Question

0.00/5 (No votes)

See more:

Hello
I wrote this piece of code for generating a random binary number with two for loop like the following:

C++

<pre>srand(time(0));
	for (i = 1; i <= 11; i++)                                                               
	{                                                                                       
		buffer.push_back(i);
	}
	for (i = 1; i <= buffer.size(); i++)
	{
		buffer[i] = rand() % 2;
		std::cout << buffer[i] % 2 << " ";
	}
	std::cout << std::endl;

there are 2 problems :
1) when I replace it in the proper place in my whole code, the compiler(in visual studio 2017) give me a warning about this line: srand(time(0)); that (Warning C4244 'argument': conversion from 'time_t' to 'unsigned int', possible loss of data)

2)how I can decrease the number of for loop to have just one for loop?

What I have tried:

<pre lang="c++">
srand(time(0));
	for (i = 1; i <= 11; i++)                                                               
	{                                                                                       
		buffer.push_back(i);
	}
	for (i = 1; i <= buffer.size(); i++)
	{
		buffer[i] = rand() % 2;
		std::cout << buffer[i] % 2 << " ";
	}
	std::cout << std::endl;

Posted 22-Apr-18 7:41am

MK2266

Updated 22-Apr-18 10:15am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

KarstenK · Answer 1 · 2018-04-22T07:49:00

The type conversion warning is normal and can be supressed. Why dont you write it in one loop?

C++

srand((unsigned int) time(0));

for (i = 1; i <= 11; i++)                                                               
{                                                                                       
	buffer.push_back(i);

	buffer[i] = rand() % 2;
	std::cout << buffer[i] << " ";// giving the result out ???
}

Rick York · Answer 2 · 2018-04-22T10:16:00

Why are you taking the modulus of two twice? Actually, why do it at all? Usually the way rand is used is you define a range for your values and write it as

C++

value = rand() % maxValue;

Then values will have a range of zero to maxValue. In the "what you have tried section", the first loop only serves the purpose of initializing the vector. This could be written as :

for( i = 0; i < valueCount; ++i )
{
    int value = rand() % maxValue;
    buffer.push_back( value );
}

You need to define the variables valueCount and maxValue to make this usable. The return of rand will range from 0 to RAND_MAX. You can initialize the vector to a given size with reserve(). If you know how many you are going to have that can be a good idea. Mostly for large numbers so there no reallocations.

Random binary number generator

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0