How to struct/rewrite this code properly ?

Question

0.00/5 (No votes)

See more:

class Program
    {
        static void Main(string[] args)
        {
            char c = 'x';
            Console.Write("Input string: ");
            string str = Console.ReadLine();
            for (int i = 0; i < str.Length; i++)
            {
                c = str[i];
                if (System.Char.IsSymbol(c) || System.Char.IsSeparator(c) || System.Char.IsWhiteSpace(c))
                {
                    Console.WriteLine("Integers and identifiers can not be symbols, space or contain them");
                }
            }
            int a;
            bool check = int.TryParse(str, out a);
            if (check == true)
            {
                Console.WriteLine("The input string is an integer.");
            }
            if (check == false)
            {
                Console.WriteLine("The input string is an identifier.");
            }
        }
    }
}

What I have tried:

The problem is : " Create a method, which checks if input string is an Integer or Identifier." My code seems to be not right because when I input "abc abc" or "$abc" as a string the output is :

Integers and identifiers can not be symbols, space or contain them
The inputed string is an identifier.
Press any key to continue . . .

Posted 16-Nov-17 23:41pm

Member 13504137

Updated 16-Nov-17 23:58pm

Add a Solution

Comments

CHill60 17-Nov-17 5:50am

When you have finished your loop your code goes straight into the check for integer. Try adding a bool to flag that an error is already found and surround your integer/identifier check with an if statement

BillWoodruff 17-Nov-17 19:33pm

There are different ways you could interpret "the problem" as you describe it.

I suspect the "correct" (what your course asks for) solution does not allow the user to enter an entire line of text at a time. I can't imagine doing that in "real world" code.

Please clarify. Ask me, if you want to see a diffewrent technique.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2017-11-16T23:58:00

The problem is that if you find a problem in your string, you don't do anythign about it, other than tell the user.
Add a return to the if code:

c = str[i];
 if (System.Char.IsSymbol(c) || System.Char.IsSeparator(c) || System.Char.IsWhiteSpace(c))
 {
     Console.WriteLine("Integers and identifiers can not be symbols, space or contain them");
     return;
 }

And it should work.
But I'd either use a foreach loop instead of the for:

C#

foreach (char c in str)
   {
   ...
   }

Or use the the built in method Any (but that may be a bit advanced for you at this stage):

if (str.Any(c => char.IsSymbol(c) || char.IsSeparator(c) || char.IsWhiteSpace(c)))
    {
    Console.WriteLine("Integers and identifiers can not be symbols, space or contain them");
    return;
    }

CHill60 · Accepted Answer · 2017-11-16T23:58:00

Try something like this (untested)

ass Program
{
    static void Main(string[] args)
    {
        char c = 'x';
        Console.Write("Input string: ");
        string str = Console.ReadLine();
                
		if ValidInput(str)
		{
			int a;
			bool check = int.TryParse(str, out a);
			if (check)
			{
				Console.WriteLine("The input string is an integer.");
			}
			else
			{
				Console.WriteLine("The input string is an identifier.");
			}
		}
		else
		{
			Console.WriteLine("Integers and identifiers can not be symbols, space or contain them");
		}
    }
	bool ValidInput(string x)
	{
		ValidInput = true;
		for (int i = 0; i < str.Length; i++)
        {
            c = str[i];
            if (System.Char.IsSymbol(c) || System.Char.IsSeparator(c) || System.Char.IsWhiteSpace(c))
            {
                ValidInput = false;
				exit for;
            }
        }
	}
}

Note you do not need = true for bools. And if a bool is not true then it must be false - so no need for the second if

How to struct/rewrite this code properly ?

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0