Click here to Skip to main content
15,886,693 members
Please Sign up or sign in to vote.
1.44/5 (2 votes)
See more:
#include<iostream>
#include<cmath>
using namespace std;
int main()
{
int n1,r,n2,p,i;
n2=i=0;
cout<<"enter the no.\n";
cin>>n1;
p=n1;
while(p!=0)
{
p=p/10;
i++;
}
p=n1;
while(p!=0)
{
r=p%10;
p=p/10;
n2=n2+pow(r,i);
}
if(n1==n2)
cout<<n1<<" is an armstrong number\n";
else
cout<<n1<<" is not an armstrong number\n";
}

What I have tried:

when variable n1=153 then the 2nd iteration of while loop is showing wrong value of variable n2 it should be 27+125=152 but instead of this it is showing 27+124=151. Hence at final output it shows 153 as non armstrong number. PLEASE CHECK THIS PROBLEM AND SEND FEEDBACK TO ME.
THANK YOU
Posted
Updated 28-Jul-21 3:42am
Comments
Mohibur Rashid 11-Jun-18 1:14am    
What compiler are you using?

Quote:
My program to check for armstrong number is showing 153 as non armstrong number.

Your problem is that you mix floating point functions and integer arithmetic.
Consider than the floating point value of an integer is never exact, thus your problem.
pow() is double.
 
Share this answer
 
v2
Comments
CPallini 10-Jun-18 16:48pm    
Good catch. My 5.
Patrice T 10-Jun-18 18:37pm    
Thank you
krpiyush29 11-Jun-18 1:43am    
thank you. that really worked. i initialized n2,r and i as double. now it has no error. it is showing 153 as an armstrong number.
THANKS AGAIN
Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C#
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
 
Share this answer
 
Put a breakpoint at the beginning of the main method, launch your solution in debug mode, and start watching for the place where your algorithm differs from what you expect.
If you do need help with debugging, what it is for and how it is done, then we can provide appropriate information sources. Debugging is not optional for a developper, it is a must-know for anyone who wants to be serious about development.
 
Share this answer
 
As suggested by ppolymorphe use integer operations. Try, for instance:
C++
#include<iostream>
#include <vector>
#include <cassert>
using namespace std;


bool is_armstrong( int n )
{
  assert( n>0 && n<1000000000 );
  vector <int> dv;

  int m = n;
  while ( m )
  {
    dv.push_back(m % 10);
    m /= 10;
  }

  int digits = dv.size();
  m = 0;
  for ( auto d: dv )
  {
    int k = d;
    for ( int i = 1; i<digits; ++i)
      k *= d;
    m+=k;
  }

  return (m == n);
}


int main()
{
  for ( int n=1; n<10000; ++n)
    if ( is_armstrong(n) )
      cout << n << '\n';

  cout << endl;
}
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900