What is wrong with my code

Question

1.00/5 (2 votes)

See more:

/*Write a program in C to find the sum of the series 1!/1+2!/2+3!/3+4!/4+5!/5 using the function. Go to the editor
Expected Output :

 The sum of the series is : 34 */
 #include <stdio.h>
 int fact(int);
 main()
 {	int i,y,sum=0,n;
 	printf("enter the number end of the series");
 	scanf("%d",&i);
 	printf("entrr the number ");
 	scanf("%d",&n);
	 for(i;i<=n;i++)
 	{
	 y=fact(i)/i;
 	sum=sum+y;
 	}
 	printf("the sum is %d",sum);
 }
 int fact(int x)
 {
 	int z,f=0;
 	
 	for(z=x-z;z=x;z--)
 	{
 		 f=f*z;
	 }
	 return (f);
 }

What I have tried:

/*Write a program in C to find the sum of the series 1!/1+2!/2+3!/3+4!/4+5!/5 using the function. Go to the editor
Expected Output :

 The sum of the series is : 34 */
 #include <stdio.h>
 int fact(int);
 main()
 {	int i,y,sum=0,n;
 	printf("enter the number end of the series");
 	scanf("%d",&i);
 	printf("entrr the number ");
 	scanf("%d",&n);
	 for(i;i<=n;i++)
 	{
	 y=fact(i)/i;
 	sum=sum+y;
 	}
 	printf("the sum is %d",sum);
 }
 int fact(int x)
 {
 	int z,f=0;
 	
 	for(z=x-z;z=x;z--)
 	{
 		 f=f*z;
	 }
	 return (f);
 }

Posted 27-Oct-21 20:16pm

Animesh Maity

Updated 27-Oct-21 20:43pm

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

KarstenK · Answer 1 · 2021-10-27T20:32:00

Use need to learn to use the debugger. Search some tutorial to figure it out.
As I see you have -not surprisingly- some bugs in your code.

C++

int fact(int x)
 {
 	int z,f=0;
 	
 	// for(z=x-z;z=x;z--) <= the buggy code
    for(z=0;z<x;z--)

additional tip: use better names, factorial for the function.

CPallini · Answer 2 · 2021-10-27T20:43:00

First:

n!/n = (n*(n-1)*..*1)/n = (n-1)*(n-2)*..*1 = (n-1)!

hence your task, for a given n, is finding the sum of

0! + 1! + .. + (n-1)!

Then, your factorial function is broken, because z is uninitialized.

Try

C

#include <stdio.h>
int fact(int);
int main()
{
  int n, sum;

  printf("enter the number ");
  if ( scanf("%d",&n) != 1)
    return -1;

  sum = 0;
  for(int i=0; i < n; ++i)
  {
    sum += fact(i);
  }

  printf("the sum is %d\n",sum);
 }

int fact(int x)
{
  int f = 1;

  for (int i = 1; i <= x; ++i)
  {
    f *= i;
  }

   return f;
}

What is wrong with my code

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0