Please what is wrong with this code?

Question

1.00/5 (2 votes)

See more:

C

#include <stdio.h>

int main()
{
    int number1;
    float number2;

    printf("Enter Integer:");
    scanf("%d",&number1);

    printf("Enter Float:");
    scanf("\n%f",&number2);

    printf("The Resulting Integer Is: %d",&number1);
    printf("\nThe Resulting Float Is: %f",&number2);

    return 0;
}

What I have tried:

Please what is wrong with this code?

Posted 14-Dec-23 12:47pm

Othniel Kingsley

Updated 14-Dec-23 13:45pm

Dave Kreskowiak

v2

Add a Solution

2 solutions

Solution 2

When you print them out using & gives the address of number1 and number 2, you don't want the address you want the value.

C++

#include <stdio.h>

int main()
{
	int number1;
	float number2;

	printf("Enter Integer:");
	scanf("%d", &number1);

	printf("Enter Float:");
	scanf("\n%f", &number2);

	printf("The Resulting Integer Is: %d", number1);
	printf("\nThe Resulting Float Is: %f", number2);

	return 0;
}

Posted 14-Dec-23 14:26pm

Mike Hankey

Updated 14-Dec-23 14:29pm

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Rick York · Accepted Answer · 2023-12-14T14:23:00

C++

printf("The Resulting Integer Is: %d",&number1);
printf("\nThe Resulting Float Is: %f",&number2);

The problem is in these two lines of code. The function printf expects its arguments to be passed by value and you are passing their addresses. To correct this you can remove the ampersands so it looks like this :

C++

printf("The Resulting Integer Is: %d\n", number1);
printf("The Resulting Float Is: %f\n", number2);

Note that I moved the new line character. I prefer to always follow a line of text with the new line character so that subsequent lines start at column zero. This is a habit I got into a long, long time ago.

One other note - I prefer to use the function fgets[^] to obtain input from a console. It includes the new line character in the string and has less quirky behavior than scanf[^]. Then one can call atoi[^] and atof[^] to get their respective numerical values. For your purposes, it does not matter that the new line character is included because the conversion functions ignore it.