Syntax error in Update statement.

Question

0.00/5 (No votes)

See more:

Syntax error in update statement, any clue ?

C#

try
{
   DialogResult dr = MessageBox.Show("Are you sure you want to update?", "Details Updation", MessageBoxButtons.YesNo, MessageBoxIcon.Question);
   if (dr == DialogResult.No)
   {
      return;
   }
   else
   {                    
      OleDbConnection oleDbConnection = new OleDbConnection(@"Provider=Microsoft.Jet.OLEDB.4.0;Data Source=users.mdb;Persist Security Info=False");
      OleDbCommand update = new OleDbCommand("UPDATE users SET user = '"+textBox2.Text+"' where code = 1", oleDbConnection);
      oleDbConnection.Open();
      update.ExecuteNonQuery();
      oleDbConnection.Close();

      MessageBox.Show("User name updated successfully", "Update Username", MessageBoxButtons.OK, MessageBoxIcon.Information);
   }
}
catch (SystemException se)
{
   MessageBox.Show(se.Message);
}
finally
{

}

Posted 25-Mar-15 20:35pm

Member 11160992

Updated 25-Mar-15 20:41pm

phil.o

v2

Add a Solution

Comments

Suvendu Shekhar Giri 26-Mar-15 2:42am

Everything looks fine. Only make sure that you are not passing special characters in the textbox which can mean different while evaluating the string expression.

Member 11160992 26-Mar-15 2:58am

Hi, thanks for reply. No special characters are there. I am passing as simple as abc

Suvendu Shekhar Giri 26-Mar-15 3:01am

Then, check once if you have written correct names for table and columns.

Sinisa Hajnal 26-Mar-15 3:00am

In the textbox2 you cannot use O'Reily or similar names because apostrophe (') ends your string. Also, consider what would happen if you enter: '; DROP USERS; -- into the textbox...

NEVER, EVER put user input directly into your system. Use stored procedure or at least parametrized query. At the very least use some checking of the content...for example, if you replace ' with '' (that is two apostrophes, not quotes) it will be escaped in the query and you'll get the name into the database

Member 11160992 26-Mar-15 3:21am

Nope, checked everything, but exhausted however the same syntax for updating password is working fine. Below is the syntax

//int number = int.Parse(comboBox1.Text);
OleDbConnection oleDbConnection = new OleDbConnection(@"Provider=Microsoft.Jet.OLEDB.4.0;Data Source=users.mdb;Persist Security Info=False");
OleDbCommand update = new OleDbCommand("UPDATE users SET pass = '" + textBox36.Text + "' where code = 1", oleDbConnection);
oleDbConnection.Open();
update.ExecuteNonQuery();
oleDbConnection.Close();

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-03-25T21:00:00

Please, don't do it like that. Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

That may cure your problem on it's own, but in addition "USER" is an SQL and ACCESS reserved word, so you shouldn't be using it as a column name. If you do, you should excape it with swaure brackets:

C#

OleDbCommand update = new OleDbCommand("UPDATE users SET [user] = ...

But seriously, use parametrized queries, or your best mate will delete your database just to see the look on your face...