Click here to Skip to main content
15,394,479 members
Articles / Desktop Programming / MFC
Posted 26 Feb 2002


35 bookmarked

Example of CListCtrl::SortItems(...) in MSDN

Rate me:
Please Sign up or sign in to vote.
2.64/5 (12 votes)
27 Feb 2002
The given example in the documentation of CListCtrl::SortItems(...) shows us exactly the WRONG way of using the function.

If we look at the documentation of CListCtrl::SortItems(...) in MSDN we find the following example of how to sort the items in reverse alphabetical order:

// Sort the item in reverse alphabetical order.
static int CALLBACK 
MyCompareProc(LPARAM lParam1, LPARAM lParam2, LPARAM lParamSort)
   // lParamSort contains a pointer to the list view control.
   CListCtrl* pListCtrl = (CListCtrl*) lParamSort;
   CString    strItem1 = pListCtrl->GetItemText(lParam1, 0);
   CString    strItem2 = pListCtrl->GetItemText(lParam2, 0);

   return strcmp(strItem2, strItem1);

void snip_CListCtrl_SortItems()
   // The pointer to my list view control.
   extern CListCtrl* pmyListCtrl;

   // Sort the list view items using my callback procedure.
   pmyListCtrl->SortItems(MyCompareProc, (LPARAM) pmyListCtrl);
This approach obviously does not work and here is why: The parameters of MyCompareProc(...) - lParam1 and lParam2 are not the index of the items but their 32-bit associated value.

There is a second problem: even if we set the 32-bit associated value of each item to be the same as the item's index this example will still not work. This is because the items will shift positions after each call to MyCompareProc(...) and the 32-bit associated values will no longer represent the item's index.

The function CListCtrl::SortItems(...) is only usefull if we store a pointer in the 32-bit associated value and we want to sort the items by some value that comes from that pointer.

One easy way of implementing reverse alphabetical sort in CListCtrl derived class is using an STL set:

#pragma warning(disable : 4786)
#include <functional>
#include <set>

struct LVITEM_less : public std::binary_function<LVITEM*, LVITEM*, bool>
    bool operator()(const LVITEM* pItem1, const LVITEM* pItem2) const
        CString strItem1(pItem1->pszText);
        CString strItem2(pItem2->pszText);

        return (strItem1 < strItem2);

void CSortableListCtrl::SortItemsDescending()
    // Sort all items in descending aphabetical order using an STL set
    typedef std::set<LVITEM*, LVITEM_less> ItemSet;
    ItemSet setItems;
    int iCount = GetItemCount();
    for (int i = 0; i < iCount; i++)
        LVITEM* pLVI = new LVITEM();
        ::memset(pLVI, 0, sizeof(LVITEM));
        pLVI->iItem = i;
        pLVI->pszText = new TCHAR[1024];
        pLVI->cchTextMax = 1024;


    // Remove all items from the list control

    // Put the items back in the list control in reverse order
    int iIndex = 0;
    for (ItemSet::reverse_iterator it = setItems.rbegin(); it != setItems.rend(); ++it)
        (*it)->iItem = iIndex++;
        delete [] (*it)->pszText;
        delete *it;


This article has no explicit license attached to it but may contain usage terms in the article text or the download files themselves. If in doubt please contact the author via the discussion board below.

A list of licenses authors might use can be found here


About the Author

Ivor S. Sargoytchev
Software Developer (Senior)
Canada Canada
No Biography provided

Comments and Discussions

QuestionIgnoring the repeatations Pin
At_work3-Jun-08 22:06
MemberAt_work3-Jun-08 22:06 
QuestionExplanation Pin
tom groezer25-May-07 12:08
Membertom groezer25-May-07 12:08 
GeneralMuch simpler solution!! Pin
Andy Bray3-Aug-06 23:30
MemberAndy Bray3-Aug-06 23:30 
Generalauthor does not understand how to use the sort issue at all Pin
includeh1016-Jun-06 4:19
Memberincludeh1016-Jun-06 4:19 
GeneralI use it with NO problem Pin
RancidCrabtree24-Aug-05 9:36
MemberRancidCrabtree24-Aug-05 9:36 
GeneralRe: I use it with NO problem Pin
Leonhardt Wille11-May-06 21:29
MemberLeonhardt Wille11-May-06 21:29 
GeneralError correction of MSDN Sample... Pin
martin.compel22-May-03 6:18
Membermartin.compel22-May-03 6:18 
GeneralRe: Error correction of MSDN Sample... Pin
Anonymous27-Aug-03 5:23
MemberAnonymous27-Aug-03 5:23 
GeneralRe: Error correction of MSDN Sample... Pin
Priya_Sundar16-Apr-08 2:50
MemberPriya_Sundar16-Apr-08 2:50 
GeneralRe: Error correction of MSDN Sample... Pin
Anonymous15-Oct-03 3:58
MemberAnonymous15-Oct-03 3:58 
GeneralRe: Error correction of MSDN Sample... Pin
cibercop16-Aug-05 5:55
Membercibercop16-Aug-05 5:55 
Generalmore simple example . Pin
radezz15-Sep-05 12:28
Memberradezz15-Sep-05 12:28 
QuestionHow to: make lParam1 and lParam2 being indices Pin
8-Apr-02 1:14
suss8-Apr-02 1:14 
AnswerRe: How to: make lParam1 and lParam2 being indices Pin
rsmenezes25-Aug-02 7:20
Memberrsmenezes25-Aug-02 7:20 
GeneralAlternative to slow SortItems Pin
Tim Kosse28-Feb-02 7:19
MemberTim Kosse28-Feb-02 7:19 
GeneralRe: Alternative to slow SortItems Pin
Ivor S. Sargoytchev28-Feb-02 7:26
MemberIvor S. Sargoytchev28-Feb-02 7:26 
GeneralThis was the Introduction here some tips... Pin
KarstenK28-Feb-02 0:29
mveKarstenK28-Feb-02 0:29 
QuestionSolution? Pin
Davide Calabro27-Feb-02 21:33
MemberDavide Calabro27-Feb-02 21:33 
AnswerRe: Solution? Pin
Chris Maunder28-Feb-02 4:33
cofounderChris Maunder28-Feb-02 4:33 
GeneralSorry... Pin
Davide Calabro28-Feb-02 5:37
MemberDavide Calabro28-Feb-02 5:37 
GeneralRe: Solution? Pin
David Wulff28-Feb-02 13:30
MemberDavid Wulff28-Feb-02 13:30 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.