|
There is a bug in CZipper::AddFolderToZip. Look at the end of the method:
WIN32_FIND_DATA finfo;
HANDLE hSearch = FindFirstFile(szSearchSpec, &finfo);
if (hSearch != INVALID_HANDLE_VALUE)
{
do
{
if (finfo.cFileName[0] != '.')
{
char szItem[MAX_PATH];
_makepath(szItem, szDrive, szFolder, finfo.cFileName, NULL);
if (finfo.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)
{
AddFolderToZip(szItem, bIgnoreFilePath);
}
else
AddFileToZip(szItem, bIgnoreFilePath);
}
}
while (FindNextFile(hSearch, &finfo));
FindClose(hSearch);
}
As you can see each next file or directory won't be zipped if its name begins with '.'
This is obviously done in order to prevent folders with names '.' and '..' to be zipped.
One of ways to fix this bug and save the correct processing of current and parent folders is change the condition like that:
if (finfo.cFileName[0] != '.')
if (strcmp(&finfo.cFileName[0], ".") && strcmp(&finfo.cFileName[0], ".."))
|
|
|
|
|
I wanted to use the CZipper class with latest zlib (ver 1.2.3). In the process I came across two issues.
ISSUE #1: The constructor does not initialize m_uzFile to NULL. The existing code is as follows:
CZipper::CZipper(LPCTSTR szFilePath, LPCTSTR szRootFolder, bool bAppend) : m_uzFile(0)
{
CloseZip();
if (szFilePath)
OpenZip(szFilePath, szRootFolder, bAppend);
}
bool CZipper::CloseZip()
{
int nRet = m_uzFile ? zipClose(m_uzFile, NULL) : ZIP_OK;
...
}
Since m_uzFile is non-NULL zipClose(m_uzFile, NULL) is called and fails. An exception is thrown.
ONE SOLUTION #1:
Do not call CloseZip() in the constructor and initialize all member variables in the constructor. (I personally like to minimize function calls in constructors.)
ISSUE #2: Appending to an existing zip file overwrites the contents.
In CZipper::OpenZip() the following call is made with bAppend = true:
m_uzFile = zipOpen(szFullPath, bAppend ? 1 : 0).
RESULTS #2:
This deletes the existing zip file's contents and adds a new the file.
EXPECTED RESLUTS #2:
I expect the new file to be APPENDED to the zip file. The existing contents should remain.
SOLUTION #2:
I made the following change that seems to work:
m_uzFile = zipOpen(szFullPath, bAppend ? APPEND_STATUS_ADDINZIP : APPEND_STATUS_CREATE);
zip.h has the following definitions:
#define APPEND_STATUS_CREATE (0)
#define APPEND_STATUS_CREATEAFTER (1)
#define APPEND_STATUS_ADDINZIP (2)
APPEND_STATUS_ADDINZIP is used in zip.c to control the appending code. APPEND_STATUS_CREATEAFTER is never referenced.
Cheers!
|
|
|
|
|
I tried to use your lib with a UNICODE project, but I could not compile with it. May you help me for this
Thanks in advance
Thuy
|
|
|
|
|
I modified some codes, so that it can be used for a UNICODE program. Because the lib is fixed, it still can not be used for a UNICODE file name.
Any one need, pls contact me
|
|
|
|
|
A few weeks ago, I saw this nice code to wrap the ZLib/ZIP functionality in a comfortable way.
Nearly everything works fine to zip folders and their subfolders together in one zip file.
Only the XP unzipping feature has problems with subfolders in the zip files.
Double clicking a zip file in windows XP starts the Extraction Wizard and during decompression a password should be entered for all files in subfolders.
This behaviour does not appear while decompressing with other zip tools like WinZip or TotalCommander.
Can anyone reproduce this problem or has a solution?
Stefan Frank
|
|
|
|
|
I've found the source code which produces the problem.
In the method "CZipper::AddFolderToZip", the following code wants to generate a directory. I think this was a previous correction to store empty folders in the zip.
if (lstrlen(szFolderName))
{
int nRet = zipOpenNewFileInZip(m_uzFile,
szFolderName,
&zfi,
NULL,
0,
NULL,
0,
NULL,
Z_DEFLATED,
Z_DEFAULT_COMPRESSION);
zipCloseFileInZip(m_uzFile);
}
I've commented it out, because I don't want to store empty folders and then the XP unzipping feature does not make any problems.
Stefan Frank
|
|
|
|
|
Hi - I have been trying to use ZSEEK to set the file pointer as I need to "rewind" a bit, but without any luck. Does anyone have an example of how to do this?
Paul
|
|
|
|
|
Hi,
Firstly, let me say a big THANK YOU for the code. It is very easy to use and extremely useful, especially considering the ugly raw interface of zlib.
Now to business. I am using the latest version of the CZipper class (downloaded from www.abstractspoon.com) and I noticed some weird behaviour.
I have a collection of files and folders in the root directory of the zip file and while some programs (e.g. WinZip) can use the resulting zip files without any problems, other programs (e.g. Google Earth) cannot. [In case you are wondering, I use CZipper to create Google Earth KMZ archives]. After a lot of debugging and frustration, I realised that the problem lies with the _alphabetical_ ordering of the files and folders in the zip archive. To be more precise, this works:
root/
|
|-- A/ => Folder A
|-- Z/ => Folder Z
|-- F => File F This doesn't:
root/
|
|-- A/ => Folder A
|-- B/ => Folder B
|-- F => File F The difference is the name of the file and the alphabeticaly last folder. If the name of the file is alphabetically AFTER the name of the last folder, the archive is not usable by some aplications.
Before you rush to accuse Google Earth for this weird behaviour, I also unzipped the file and rezipped it with WinZip, in which case Google Earth was more than happy to load it. This all points to a problem in the CZipper class, but I have been unable to locate the source of the problem.
Any help will be greatly appreciated! Many thanks.
--
/stokos
|
|
|
|
|
Dan, Your code was really helpful
Think you can post (or send me) the updated code ? (with the bug fixes mentioned in the comments)
Thanks,
Daniel C.
[SDE, Sydney, AU]
djc@walla.com
|
|
|
|
|
Hi Dang.
Thanks for the codes.
BTW I found that the unzip didn't work properly if the zipped file has more than one layer of subdir, i.e. the files under two layers of subdire could not be unzipped correctly. EG. myfile.zip with
\*.*
\sub1\*.* // no problem
\sub1\sub2\*.* // having troubles
The unzip program of your other article "C++ wrapper for Gilles Vollant's Unzip API" works alright. But the check box of Ignore path information... not working. Checked or unchecked makes no difference.
Regards,
Ke
|
|
|
|
|
unzipping does not work.
The unzip program of your other article "C++ wrapper for Gilles Vollant's Unzip API" works alright. But it does unzip a empty subdire in *.zip.
|
|
|
|
|
Line 443 in Unzipper.cpp, *CHANGE* these:
if (!::CreateDirectory(szFolder, NULL))
return FALSE;
AS:
if (!::CreateDirectory(szFolder, NULL)) {
DWORD dwRet = GetLastError();
if(dwRet != ERROR_ALREADY_EXISTS)
return FALSE;
}
|
|
|
|
|
I'm trying to generate an OpenOffice .odt file (a Zip file containing xml files) automatically.
If I zip up the files using IZArc or other Zip programs, I can open them in OpenOffice OK. If I use this class, OO complains that the file is corrupt. However, if I open the Zip file, extract the files and re-zip them using another program then they work fine in OpenOffice.
Any idea what's different between the zip files produced by this code and the zip files that IZArc and other programs produce?
|
|
|
|
|
The last time I looked at this class, there was a problem with is using the wrong path separator character. The ZIP standard defines it as '/', but this class uses '\'.
Some archiver apps handle both '/' and '\' which is why you can open the archive in them, but I would guess that OO is more strict and only allows the '/'.
|
|
|
|
|
Thanks for the suggestion. I got round it in the end by opening a zip file I created using another program and just using this class to add the main content file.
|
|
|
|
|
Zipper.cpp: AddFolderToZip(LPCTSTR szFolderPath, bool bIgnoreFilePath)
line 343 you can modify
lstrcat(szFolderName, "\\");
to.
lstrcat(szFolderName, "/");
-- modified at 5:30 Friday 3rd August, 2007
|
|
|
|
|
http://www.abstractspoon.com/ seems to contain a newer version with many fixes...
would be nice if these could be updated as well...
|
|
|
|
|
Hi. Thanks for this project. I like it. But I get these linking errors:
test error LNK2005: _exit bereits in msvcrtd.lib(MSVCR71D.dll) definiert<br />
test error LNK2005: __exit bereits in msvcrtd.lib(MSVCR71D.dll) definiert<br />
test error LNK2005: __cexit bereits in msvcrtd.lib(MSVCR71D.dll) definiert<br />
test error LNK2005: __c_exit bereits in msvcrtd.lib(MSVCR71D.dll) definiert<br />
test error LNK2005: ___xc_z bereits in msvcrtd.lib(cinitexe.obj) definiert<br />
test error LNK2005: ___xc_a bereits in msvcrtd.lib(cinitexe.obj) definiert<br />
test error LNK2005: ___xi_z bereits in msvcrtd.lib(cinitexe.obj) definiert<br />
test error LNK2005: ___xi_a bereits in msvcrtd.lib(cinitexe.obj) definiert<br />
test warning LNK4098: Standardbibliothek 'msvcrtd.lib' steht in Konflikt mit anderen Bibliotheken; /NODEFAULT:Bibliothek verwenden<br />
test warning LNK4098: Standardbibliothek 'LIBC' steht in Konflikt mit anderen Bibliotheken; /NODEFAULT:Bibliothek verwenden<br />
test warning LNK4098: Standardbibliothek 'msvcrt.lib' steht in Konflikt mit anderen Bibliotheken; /NODEFAULT:Bibliothek verwenden<br />
test fatal error LNK1169: Ein oder mehrere mehrfach definierte Symbole gefunden<br />
Sorry for the german output, but it should basicly mean the same in english
|
|
|
|
|
How do I zip sub folders into one .zip folder?
|
|
|
|
|
Hi,
I had a problem with CUnzipper::Unzip below, when szFileName and szFolder had different root directories and the zip contained multiple empty intermediate directory levels (only subdirs, no files).
I used 2 steps to fix the problem:
a) in
// static version
bool CUnzipper::Unzip(LPCTSTR szFileName, LPCTSTR szFolder, bool bIgnoreFilePath)
{
CUnzipper unz;
if (!unz.OpenZip(szFileName))
return FALSE;
//MKinsert >>
if(szFolder && strlen(szFolder))
unz.SetOutputFolder(szFolder);
//<< MKinsert
return unz.UnzipTo(szFolder, bIgnoreFilePath);
}
b) in
bool CUnzipper::CreateFolder(LPCTSTR szFolder)
{
...
free(szPath);
//MKinsert >>
dwAttrib = GetFileAttributes(szFolder);
// already exists ?
if (dwAttrib != 0xffffffff)
return ((dwAttrib & FILE_ATTRIBUTE_DIRECTORY) == FILE_ATTRIBUTE_DIRECTORY);
//<< MKinsert
if (!::CreateDirectory(szFolder, NULL))
return FALSE;
...
Hoping this may also help others
Regards
Martin
|
|
|
|
|
why can't winzip open the created zip file, when I create a Sub-Folder(tried: \0\;\0;0\;0)?
(sometimes WinRar can)
|
|
|
|
|
Is there some way of using zlib (and your interface) to create zip files larger than 2Gig? There isn't any error but the zip file ends up being corrupted.
thx
John
|
|
|
|
|
How do you append a zip file. I have tried the following:
zip.OpenZip(existing zip,NULL,TRUE);
When I do this the files already in the existing zip are removed and replaced by the files I was trying to append to the zip.
Thanks.
j
|
|
|
|
|
How do you choose the destination folder for a zip file?
J
|
|
|
|
|
to specify the destination path you need to use the extended zip interface like this:
<br />
CZipper zip;<br />
<br />
if (zip.OpenZip([dest folder + filename.zip]))<br />
{<br />
zip.AddFileToZip(...);<br />
zip.AddFileToZip(...);<br />
<br />
zip.CloseZip();<br />
}<br />
rgds
.dan.g.
AbstractSpoon Software
|
|
|
|