|
I want use ceditlog in my system but I have some log level, and I want add color to each level
if this possible
thank
herzl
|
|
|
|
|
Dear Mr. Daniel Lohmann,
How are you? Thank you for your fast logging edit control.
CLogEdit control works (compile, link and execute by using VS 2008) like a charm on Windows XP operating system. On Windows Vista, CLogEdit control can pass compiling and linking, but con't run anymore. I trace from the application entry point step by step, and finally find an error in the statement ::SendMessage( hEdit, EM_LIMITTEXT, 0, 0 );
of the following routine:
void CEditLog::SetEditCtrl(
HWND hEdit
)
{
if( hEdit != GetHandle() && GetHandle() != NULL )
UnsubclassWindow();
if( SubclassWindow( hEdit ) ) {
// We want to support a lot of text...
// Note that Win9x supports no more than 64kb of text! - just too bad...
// Tip: Use NT/2k
::SendMessage( hEdit, EM_LIMITTEXT, 0, 0 );
}
}
When single-steped into the statement ::SendMessage( hEdit, EM_LIMITTEXT, 0, 0 ); an error message box was throwed, and said "Unhandled exception at 0x03613d1c in GVIPS.exe: 0x0000005; Access violation."
Could you help me to figure out this error. Thank you!
|
|
|
|
|
Hi,
I am sorry, but my current work load does not leave me any time to look into this; moreover, I do not have a Vista box
I assume, however, that the problem lies somewhere in the CSublassWindow-Code and the way it creates the Thunk-Code in a member variable. Probably Vista marks all data segments with the "no-exec" Flag supported by newer IA32/64 CPUs, which results in the Access Violation.
Maybe there is a newer Version of CSubclassWindow available somehwere (I found the original one here on CodeProject, but apparently it disappeared). Otherwise, someone has to rewrite the code so that the memory for the Tunk data structure is allocated from an executable memory region (VirtuallAlloc()). Another, simpler approach might be to use VirtualProtect() to set the "X"-flag on the memory region the Thunk member variables belong to.
--
Daniel Lohmann
http://www.losoft.de
(Hey, this page is worth looking! You can find some free and handy NT tools there )
|
|
|
|
|
I have the same problem run on Windows 7. After setting the project property "Data Execution Prevention (DEP)" to off, the problem disapperred. Project property > Linker > Advanced > Data Execution Prevention (DEP) > Default or (/NXCOMPAT:NO). You can try it.
Y.S. Liou
|
|
|
|
|
Hi,
I took a look at the source code and found the problem. The CSubclassWnd class was written way back around 2000+/- by William E. Kempf. Back then processors did not have the NX bit and you could execute code located at arbitrary memory addresses with no problems. Today on more modern hardware/operating systems you will of course receive a DEP error.
In the file SubclassWnd.h find the the code block:
#if defined (_M_IX86)
thunk.m_mov = 0x042444C7; thunk.m_this = (DWORD)pThis;
thunk.m_jmp = 0xe9;
thunk.m_relproc = (int)proc - ((int)this+sizeof(Thunk));
#elif defined (_M_ALPHA)
Then change the memory protection on the thunk so it is executable:
#if defined (_M_IX86)
thunk.m_mov = 0x042444C7; thunk.m_this = (DWORD)pThis;
thunk.m_jmp = 0xe9;
thunk.m_relproc = (int)proc - ((int)this+sizeof(Thunk));
DWORD dwOldProtection;
VirtualProtect(&thunk,sizeof(Thunk),PAGE_EXECUTE_READWRITE,&dwOldProtection);
#elif defined (_M_ALPHA)
Best Wishes,
-David Delaune
|
|
|
|
|
The suggested solution might be a problem as, according to MSDN, one should avoid using VirtualProtect on memory that wasn't allocated with VirtualAlloc[Ex]. VirtualProtect changes the access rights on a complete memory page. If "thunk" crosses page boundaries, it even changes the rights of two pages, but that's just details. It's not done here, but if you remove read/write access from a page within the heap, you're in really big problems.
I came up with a similar solution, which is a little bit more complicated (and hopefully better ). For Details see my message "Fix to run with Data Execution Prevention" in the article "Pluggable Event Handler"
Pluggable Event Handler[^].
|
|
|
|
|
Hi Walter,
I have not looked at your modifications but I am sure that you have done an outstanding and thorough job. I was contacted by a former co-worker to have a look at this project and tell him why it was crashing. I think I spent a total of 5 minutes looking at the code. Thanks for the improved solution.
Best Wishes,
-David Delaune
|
|
|
|
|
|
Can I use CEditLog for CRichEditCtrl?
What do I change to work it?
|
|
|
|
|
Good work, thanks!
Is there any way to control number of lines in the control? I need to log an application for many days.
|
|
|
|
|
Hi,
Great job !!!
I have a question,
My application used to be a console one and it uses printf a lot.
Is there a way to redirect printf as well ?
Thanks
|
|
|
|
|
Hello!
I met the same problem,and made no progress although i try to find many materials related to redirection problem.
Do you have any solution now? Thanks!!
|
|
|
|
|
Hi
I've download your program and try to comiple it in VC05. I've got some error message like:
"editlog.cpp(22) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int". It denotes "const WM_ADDTEXT = WM_USER + 500;" in line 22 of editlog.cpp is illegal now. I've changed it to const int and it works fine now. Anyway, thanks you to create this nice class.
Anson Chen
|
|
|
|
|
it was a mistake.
just read the error message:
const int WM_ADDTEXT = WM_USER+500;
is the correct statement.
|
|
|
|
|
Nice,
--------------------------------------------------------------------------
For high quality flow/diagram MFC/C++ Visio Like visualization Source Code,download XD++ at:
http://www.ucancode.net
|
|
|
|
|
Hi,
I'm using CEditLog to log some mathematical calculations.
However, the CEdit is not update after each cout (nor AddText) but only a the end of the computations.
Is there a way to force the update of the CEdit ?
Thanks
Vince
|
|
|
|
|
Hi Vince,
The edit control is updated "immediately" if the caret resides in the last line or at least every 500 msec. 500 msec is the default, the timeout is configurable at construction time.
Note that the update is actually performed by the thread who owns the edit control and not by the thread calling AddText() . Moreover, the UI thread (the thread owning the edit control) needs to process messages. So if your calculation thread has a higher priority than the UI thread and induces a high CPU load, this may cause the update delays as the UI thread never gets the chance to update the edit control. Maybe it would help to add a Sleep(0) after the output in the worker thread to yield the CPU to another thread.
If the calculation is actually performed by the same thread that owns the UI, this may also cause delays if your thread does not process messages during the calculations, which is required to update the UI. In this case it may help to invoke message processing explicitly.
Hope that helps
--
Daniel Lohmann
http://www.losoft.de
(Hey, this page is worth looking! You can find some free and handy NT tools there )
|
|
|
|
|
Hi,
I am trying to use CEditLog in my application (MFC MDI). I am using Scintilla edit control in place of CEdit. Everything is working fine except when I close the app there is a memory exception happenning (Could not read the memory ....). Apperantly it seems that there is a problem with the following two lines
// Redirect cout to our Edit-Control
m_pOldBuf = cout.rdbuf( &m_EditStrBuf );
// and also the unicode version
m_pOldBufW = wcout.rdbuf( &m_EditStrBufW );
Am I doing something wrong. Plase help.
|
|
|
|
|
Hi,
I think that it was not recovered stream.
Simply, We need to restore the streams.
And, I added the following code in .h and .cpp.
//
class CEditLogger : public CDialog
{
private:
std::basic_streambuf<char>* _cold_in;
std::basic_streambuf<char>* _cold_out;
std::basic_streambuf<char>* _cold_err;
std::basic_streambuf<char>* _cold_log;
std::basic_streambuf<wchar_t>* _wcold_in;
std::basic_streambuf<wchar_t>* _wcold_out;
std::basic_streambuf<wchar_t>* _wcold_err;
std::basic_streambuf<wchar_t>* _wcold_log;
protected:
CEditLog m_EditLogger;
// ANSI and UNICODE stream buffers for the EditLogger
std::editstreambuf m_EditStrBuf;
std::weditstreambuf m_EditStrBufW;
// Used to save the previos values for cout and wcout
std::basic_streambuf<char>* m_pOldBuf;
std::basic_streambuf<wchar_t>* m_pOldBufW;
:
:
}
CEditLogger::CEditLogger(CWnd* pParent /*=NULL*/)
: CDialog(CEditLogger::IDD, pParent), m_EditStrBuf( m_EditLogger ), m_EditStrBufW( m_EditLogger )
{
_cold_in = cin.rdbuf();
_cold_out = cout.rdbuf();
_cold_err = cerr.rdbuf();
_cold_log = clog.rdbuf();
_wcold_in = wcin.rdbuf();
_wcold_out = wcout.rdbuf();
_wcold_err = wcerr.rdbuf();
_wcold_log = wclog.rdbuf();
//{{AFX_DATA_INIT(CEditLogger)
// NOTE: the ClassWizard will add member initialization here
//}}AFX_DATA_INIT
}
void CEditLogger::PostNcDestroy()
{
// TODO: Add your specialized code here and/or call the base class
cin.rdbuf( _cold_in );
cout.rdbuf( _cold_out );
cerr.rdbuf( _cold_err );
clog.rdbuf( _cold_log );
wcin.rdbuf( _wcold_in );
wcout.rdbuf( _wcold_out );
wcerr.rdbuf( _wcold_err );
wclog.rdbuf( _wcold_log );
CDialog::PostNcDestroy();
}
I
|
|
|
|
|
Hello Daniel, Hello other codeproject guys!
These lines of code are really powerful - really nice component. Thank you very much or "Herzliches Dankeschön"!
I use these code in a document-view project with splitter windows. All things work well but I am not able to change the font. I am always getting a NULL pointer back, that is the code:
..CErrorEditView::OnCreate(...
{
CEdit& pme = this -> GetEditCtrl();
CFont* pf = pme.GetFont();
if (pf) <- this is always NULL
{
LOGFONT lf;
...
pf -> getLogFont(&lf);
lf.lfHeight = 15;
...
...
SetFont(pf);
}
...
}
Why I can't get a valid pointer?
This code works for other views (for instance with treeViews
Thank you very much / kind regards from Dresden
Marko Winter
SysMik GmbH Dresden
Germany
|
|
|
|
|
Are you sure this is a CEditLog related problem?
Is it working with a plain CEditView derived class that does not use CEditLog?
--
Daniel Lohmann
http://www.losoft.de
(Hey, this page is worth looking! You can find some free and handy NT tools there )
|
|
|
|
|
Hello Daniel!
Thanks for the hint - no that isn't a CEditLog related problem! I see same behaviour if I use a plain CEditView derived class.
That surprises me - because such code works with other CView derived classes.
But now I get a solution: creating a CFont member of class, setting the properties and set these font in onCreate
Thank you very much - thanks for the code too!
I wish you a nice weekend! with kind regards
Marko Winter
-------------------------------------------
Software & Systems
-------------------------------------------
SysMik GmbH Dresden | www.sysmik.de
-------------------------------------------
Dezentral automatisieren
LON over IP mit INLINE von Phoenix Contact
-------------------------------------------
SysMik | ICS – InlineControlServer
die neue Controllergeneration
-------------------------------------------
SysMik GmbH Dresden
Bertolt-Brecht-Allee 24
01309 Dresden, Germany
Tel/Fax +49-(0)351-43358 -30 / -29
-----------------------------------------
|
|
|
|
|
|
You might find thunk structure for x64 on the source: "C:\Program Files\Microsoft Visual Studio ####\VC\atlmfc\include\atlstdthunk.h", but wont works well.
I had managed to build x64 binary using other CSubclassWnd.
|
|
|
|
|
This is some outstanding code I think, very very good idea.
Well Done.
Iain Fraser
sd
|
|
|
|